i#2566 anon text: Use the app path instead of maps comments #3736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the application module, we use the application path obtained from
early injection or /proc/self/exe on Linux, rather than
/proc/self/maps comments. The maps comments can be unreliable in the
face of anonymous or deleted-file mremaps used for hugepage backing
and other features.
Adds a test case to the existing "burst_maps" test.
Having the right module full_path helps many cases, including the
forthcoming restartable sequences ("rseq") support for #2350.
Issue: #2566, #2350
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the application module, we use the application path obtained from
early injection or /proc/self/exe on Linux, rather than
/proc/self/maps comments. The maps comments can be unreliable in the
face of anonymous or deleted-file mremaps used for hugepage backing
and other features.
Adds a test case to the existing "burst_maps" test.
Having the right module full_path helps many cases, including the
forthcoming restartable sequences ("rseq") support for #2350.
Issue: #2566, #2350