VisualStudio2013 Update5 fix wrong include paths for asm_defines.asm #3656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deroko
changed the title
|
run arm tests |
derekbruening
approved these changes
May 29, 2019
|
run arm tests |
|
This shoudl fix #3613 |
|
run arm tests |
|
Hmm #3320 showed up again on Appveyor in reuse_distance test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue in x86/x64 build of DynamoRIO where VisualStudio2013 wasn't able to build due to wrong paths for
asm_defines.asmincore/drlibc/drlibc_x86.asmandcore/drlibc/drlibc_xarch.asm.Change was tested on Windows with nmake/VisualStudio builds for both x86/x64, and also on Linux for x86/x64/arm builds with cmake/make. Ninja build, I've only tested briefly on Linux.
Now building instructions from : https://github.com/DynamoRIO/dynamorio/wiki/How-To-Build#Windows will work out of the box.