Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#2876 clang-format: check format in test suite #3094

Merged
merged 8 commits into from
Jul 9, 2018

Conversation

derekbruening
Copy link
Contributor

Adds checking of diff formatting to runsuite.cmake. If
clang-format-diff{,.py} is found, it is used to check the formatting, and
any format change is a fatal error. On Travis, not finding the program is
a fatal error.

Adds installation of clang-format-6.0 from apt.llvm.org on Travis.

Issue: #2876

Adds checking of diff formatting to runsuite.cmake.  If
clang-format-diff{,.py} is found, it is used to check the formatting, and
any format change is a fatal error.  On Travis, not finding the program is
a fatal error.

Adds installation of clang-format-6.0 from apt.llvm.org on Travis.

Issue: #2876
@derekbruening
Copy link
Contributor Author

I don't understand the AArch64 failure -- it must be getting the wrong diff, not just of this patch but the already-committed one?

CMake Error at /data/jenkins_root/workspace/DynamoRIO-AArch64-Precommit/suite/runsuite.cmake:235 (message):
  ERROR: diff contains tabs:

  -#define VC_EXTRALEAN		// Exclude rarely-used stuff from Windows headers

@derekbruening
Copy link
Contributor Author

It worked. Appveyor failed due to nudge_test (#2978) and drmgr-test (#653). Travis failed due to the threadfilter test (#2941). We should add these to the ignore list (even better to fix of course...)

Now to test a deliberate format error. I tested this locally of course, but to ensure it works on Travis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant