Fix most warnings generated by Clang 5.0 on AArch64. #2965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the dr_extend_type_t enum type, Clang decided that it is unsigned. I am not sure if we can rely on Gcc to agree or how to ensure that. Change-Id: I1ab036338939541491a4f054ea034d9b0036599a
fhahn
commented
Apr 26, 2018
| @@ -45,7 +45,7 @@ | |||
|
|
|||
| int main() | |||
| { | |||
| int pid; | |||
| int64_t pid; | |||
There was a problem hiding this comment.
Looks like the X86 inline assembly is not happy with this type. I will update that
There was a problem hiding this comment.
Shouldn't it be pid_t?
There was a problem hiding this comment.
I changed it back to int and limited the width in the AArch64 assembler.
core/arch/interp.c
Outdated
| @@ -5711,6 +5713,7 @@ tracelist_add(dcontext_t *dcontext, instrlist_t *ilist, instr_t *where, instr_t | |||
| return size; | |||
| } | |||
|
|
|||
| #ifdef X86 | |||
There was a problem hiding this comment.
We never did port traces to ARM but we should at some point, so this should not be x86-specific, or if you mark it that way at least make it clear this is temporary.
| @@ -45,7 +45,7 @@ | |||
|
|
|||
| int main() | |||
| { | |||
| int pid; | |||
| int64_t pid; | |||
There was a problem hiding this comment.
Shouldn't it be pid_t?
Change-Id: Ica446d32183aadd197b27f9da3faa7d942e50d98
derekbruening
approved these changes
Apr 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the dr_extend_type_t enum type, Clang decided that it is unsigned.
I am not sure if we can rely on Gcc to agree or how to ensure that.