i#140 pcprof: add client pc sampling support #2883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added dr_where_am_i() to better support client self-profiling via sampling. This also provides the fragment tag, by refactoring the pcprofile code into a new helper fcache_refine_whereami(). Renamed the whereami types to better avoid name conflicts: s/WHERE_xxx/DR_WHERE_xxx/ and s/where_am_i_t/dr_where_am_i_t/. Exported the dr_where_am_i_t enum. Fixed a bug where an uninitialized mcontext was passed to a client timer callback: we only filled in the mcontext for a DR-internal callback. Added a test of client sampling to client.timer Issue: #140
|
A64 is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added dr_where_am_i() to better support client self-profiling via
sampling. This also provides the fragment tag, by refactoring
the pcprofile code into a new helper fcache_refine_whereami().
Renamed the whereami types to better avoid name conflicts:
s/WHERE_xxx/DR_WHERE_xxx/ and s/where_am_i_t/dr_where_am_i_t/.
Exported the dr_where_am_i_t enum.
Fixed a bug where an uninitialized mcontext was passed to a
client timer callback: we only filled in the mcontext for a
DR-internal callback.
Added a test of client sampling to client.timer
Issue: #140