i#2708 trace discontinuity: add test, fix bugs found by test #2747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extends the trace_invariants test from #2638 to ensure there's no discontinuity in control flow not indicated by a branch or a kernel xfer marker. Adds an online trace_invariants test. Switches the trace_invariants test to run pthreads.ptsig on UNIX, which is marked un-FLAKY, to test both threads and signals, and on winxfer on Windows. Fixes several issues found by this new test: + Adds TRACE_TYPE_INSTR_SYSENTER to mark the PC discontinuity from OP_sysenter. + Adds proper handling of a mid-bb fault in offline trace conversion by looking ahead after each memref to see whether there's a marker. + #2011 follow-up: fixes the zero-iter code from 2772b0b which it turns out only worked for offline traces. For online, the top-of-bb instr is jecxz, so the instr type and size were wrong. + Fixes pipe write splitting to avoid separating an instr from its bundle entries. + Avoids a marker for a thread init kernel xfer event on Windows. Fixes #2708
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the trace_invariants test from #2638 to ensure there's no
discontinuity in control flow not indicated by a branch or a kernel xfer
marker.
Adds an online trace_invariants test.
Switches the trace_invariants test to run pthreads.ptsig on UNIX, which is
marked un-FLAKY, to test both threads and signals, and on winxfer on
Windows.
Fixes several issues found by this new test:
OP_sysenter.
looking ahead after each memref to see whether there's a marker.
only worked for offline traces. For online, the top-of-bb instr is
jecxz, so the instr type and size were wrong.
entries.
Fixes #2708