i#1729 offline traces: fix initial tid entry errors #2461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes two issues with offline traces (#1729): first, changes the reader to not assume a separate tid header right after the initial tid,pid header, as offline traces (as opposed to online) do not contain it. Second, changes raw2trace to not emit a superfluous tid entry of 0 just prior to the real initial tid entry for each thread. Adds asserts to catch related errors in the future in the test suite.
The extra checks fail on the multiproc test so we fix that here for online by adding a fork event handler that sends a new header to the simulator. We partially solve #2384 by creating a new offline dir and files but more work is needed to merge the final traces in the added test here: that's left for #2384.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two issues with offline traces (#1729): first, changes the reader to
not assume a separate tid header right after the initial tid,pid header, as
offline traces (as opposed to online) do not contain it. Second, changes
raw2trace to not emit a superfluous tid entry of 0 just prior to the real
initial tid entry for each thread.
Adds asserts to catch related errors in the future in the test suite.