i#2006 generalize drcachesim: omit log msg when file ops replaced #2177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the drmemtrace file ops are replaced, it's up the replacer to notify the user where the trace data is going. In some cases data is sent over the network and the replaced create_dir is a nop that returns true, in which case we don't want the existing message stating where the local log directory is, as there is no such directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the drmemtrace file ops are replaced, it's up the replacer to notify the
user where the trace data is going. In some cases data is sent over the
network and the replaced create_dir is a nop that returns true, in which
case we don't want the existing message stating where the local log
directory is, as there is no such directory.