AArch64 missing support for client threads #4516
Assignees
Labels
Comments
derekbruening
added a commit
that referenced
this issue
Nov 5, 2020
On ARM, the kernel xfer event code added extra calls to canonicalize_pc_target(), which can't be called twice: the ISA mode is lost then. We fix that here by refactoring the code to call just once. Tested on the client.signal test, which is ported and enabled in a forthcoming PR for #4516. Issue: #4516, #4522 Fixes #4522
derekbruening
added a commit
that referenced
this issue
Nov 5, 2020
Adds client thread support to AArchXX. Implements dynamorio_clone for both ARM and AArch64 and adds necessary TLS swapping, including handling initial tpidr* values pointing at read-only memory. Ports the client.signal test's assembly to a64 and arm. Enables the client.signal test on aarchxx. The test covers the client thread support here, as well as general client signal handling and manipulating. Tested manually on arm with the #4522 fix. Issue: #4474, #4516, #4522 Fixes #4516
derekbruening
added a commit
that referenced
this issue
Nov 5, 2020
On ARM, the kernel xfer event code added extra calls to canonicalize_pc_target(), which can't be called twice: the ISA mode is lost then. We fix that here by refactoring the code to call just once. Tested on the client.signal test, which is ported and enabled in a forthcoming PR for #4516. Issue: #4516, #4522 Fixes #4522
derekbruening
added a commit
that referenced
this issue
Nov 5, 2020
Adds client thread support to AArchXX. Implements dynamorio_clone for both ARM and AArch64 and adds necessary TLS swapping, including handling initial tpidr* values pointing at read-only memory. Ports the client.signal test's assembly to a64 and arm. Enables the client.signal test on aarchxx. The test covers the client thread support here, as well as general client signal handling and manipulating. Tested manually on arm with the #4522 fix. Issue: #4474, #4516, #4522 Fixes #4516
gregcawthorne
pushed a commit
that referenced
this issue
Nov 28, 2020
On ARM, the kernel xfer event code added extra calls to canonicalize_pc_target(), which can't be called twice: the ISA mode is lost then. We fix that here by refactoring the code to call just once. Tested on the client.signal test, which is ported and enabled in a forthcoming PR for #4516. Issue: #4516, #4522 Fixes #4522
gregcawthorne
pushed a commit
that referenced
this issue
Nov 28, 2020
Adds client thread support to AArchXX. Implements dynamorio_clone for both ARM and AArch64 and adds necessary TLS swapping, including handling initial tpidr* values pointing at read-only memory. Ports the client.signal test's assembly to a64 and arm. Enables the client.signal test on aarchxx. The test covers the client thread support here, as well as general client signal handling and manipulating. Tested manually on arm with the #4522 fix. Issue: #4474, #4516, #4522 Fixes #4516
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The AArch64 port #1569 failed to implement a number of features. This one covers client threads, which is blocking enabling tests for #4460 (also xref #4474).
The text was updated successfully, but these errors were encountered: