Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code_api|tool.drcachesim.miss_analyzer timeouts on Travis after Xenial upgrade. #3485

Closed
hgreving2304 opened this issue Mar 27, 2019 · 3 comments
Closed

code_api|tool.drcachesim.miss_analyzer timeouts on Travis after Xenial upgrade. #3485

hgreving2304 opened this issue Mar 27, 2019 · 3 comments
Assignees
@kharbutli
Labels
Component-Tests

Comments

@hgreving2304
Copy link

After #3456 , a toolchain upgrade apparently causes code_api|tool.drcachesim.miss_analyzer to sporadically run longer than 90s. Could we please cut down the test a little bit, e.g. in half?
@derekbruening derekbruening mentioned this issue Mar 27, 2019
Merged
@kharbutli kharbutli mentioned this issue Mar 27, 2019
Closed
hgreving2304 pushed a commit that referenced this issue Mar 28, 2019
i#3485: Cut down runtime of code_api|tool.drcachesim.miss_analyzer.
33f0c94 
Cuts down runtime of the drcachesim.miss_analyzer test by cutting down the number of
the main loop's iterations as well as the array size in the test.

Fixes #3485
@hgreving2304 hgreving2304 mentioned this issue Mar 28, 2019
Merged
derekbruening pushed a commit that referenced this issue Mar 28, 2019
@derekbruening
i#3485: Cut down runtime of tool.drcachesim.miss_analyzer. (#3490)
92c64fc 
Cuts down runtime of the drcachesim.miss_analyzer test by cutting down the number of
the main loop's iterations as well as the array size in the test.  The test was timing out before.

Fixes #3485
@derekbruening
Copy link
Contributor

Re-opening because of this comment from PR #3490:

It's still slower than I would vote for, and it may be possible to time out on a loaded machine:

256/308 Test #242: code_api|tool.drcachesim.miss_analyzer ....................... Passed 46.22 sec

It is still one of the slowest tests out of all 300+ tests so I would say it would be good to shrink it further, if that's not hard to do.

@derekbruening derekbruening reopened this Mar 28, 2019
@derekbruening
Copy link
Contributor

If shrinking further would compromise the test itself, then we can live with it as-is: maybe with an increased timeout in case it gets close to 90s on a loaded machine.

@kharbutli
Copy link
Contributor

PR #3529 should fix this.
Closing the issue.

AssadHashmi pushed a commit that referenced this issue Apr 11, 2019
@kharbutli
i#3485: Cut down the runtime of the test tool.drcachesim.miss_analyzer …
6edd349 
…#3529

Cut down the runtime of the test tool.drcachesim.miss_analyzer by reducing the array size and number of iterations in the main loop. The test's runtime is reduced to about one third of its original value.

Fixes #3485
hgreving2304 pushed a commit that referenced this issue Apr 22, 2019
i#3485: Cut down runtime of tool.drcachesim.miss_analyzer. (#3490)
4228a53 
Cuts down runtime of the drcachesim.miss_analyzer test by cutting down the number of
the main loop's iterations as well as the array size in the test.  The test was timing out before.

Fixes #3485
hgreving2304 pushed a commit that referenced this issue Apr 22, 2019
@kharbutli
i#3485: Cut down the runtime of the test tool.drcachesim.miss_analyzer …
9d334c9 
…#3529

Cut down the runtime of the test tool.drcachesim.miss_analyzer by reducing the array size and number of iterations in the main loop. The test's runtime is reduced to about one third of its original value.

Fixes #3485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kharbutli kharbutli

Labels
Component-Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

i#3485: Fix the flaky test tool.drcachesim.miss_analyzer DynamoRIO/dynamorio
3 participants
@derekbruening @kharbutli @hgreving2304