Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drmodtrack leaks memory on parsing errors #3314

Closed
derekbruening opened this issue Dec 15, 2018 · 0 comments · Fixed by #3500
Closed

drmodtrack leaks memory on parsing errors #3314

derekbruening opened this issue Dec 15, 2018 · 0 comments · Fixed by #3500
Labels
Component-Extension

Comments

@derekbruening
Copy link
Contributor

If drmodtrack_offline_read() hits a parsing error, it frees only its own data and never calls the
user free routine for any file lines it has already successfully parsed.
derekbruening added a commit that referenced this issue Apr 3, 2019
@derekbruening
i#3314: Free drmodtrack user memory on parsing errors
aeda018 
Adds freeing of drmodtrack custom user allocations on parsing errors.
Previously, we would leak the memory.

Adds a test to drmodtrack-test.  Confirmed that without this fix the
test fails.

Fixes #3314
@derekbruening derekbruening mentioned this issue Apr 3, 2019
Merged
derekbruening added a commit that referenced this issue Apr 3, 2019
@derekbruening
i#3314: Free drmodtrack user memory on parsing errors (#3500)
f2cf681 
Adds freeing of drmodtrack custom user allocations on parsing errors.
Previously, we would leak the memory.

Adds a test to drmodtrack-test.  Confirmed that without this fix the
test fails.

Fixes #3314
hgreving2304 pushed a commit that referenced this issue Apr 22, 2019
@derekbruening
i#3314: Free drmodtrack user memory on parsing errors (#3500)
40b11db 
Adds freeing of drmodtrack custom user allocations on parsing errors.
Previously, we would leak the memory.

Adds a test to drmodtrack-test.  Confirmed that without this fix the
test fails.

Fixes #3314
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component-Extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

i#3314: Free drmodtrack user memory on parsing errors DynamoRIO/dynamorio
1 participant
@derekbruening