improve suite/runsuite.cmake: label known failures; ssh support; results in review text #121
Comments
|
From [email protected] on May 04, 2009 21:56:51 in r155 : |
|
From [email protected] on May 30, 2010 13:53:48 running tests over ssh is split into Issue 310 |
|
From [email protected] on December 05, 2011 10:55:25 Owner: [email protected] |
derekbruening
added a commit
that referenced
this issue
Jan 12, 2024
Before, we relied on drrun -s for all test suite timeouts except for runcmp tests where we set a CTest timeout. This resulted in the default 10 minute CTest timeout for all tests, which was the only timeout for runall tests and caused long suite times on the AArch64 machine which accidentally had no ptrace privileges (#5740, #6558, Here, we set the CTest time for runall in addition to runcmp, and for all other tests with no timeout specified (which are presumably relying on drrun -s) we set a timeout of the drrun timeout plus 30 seconds. Tested on the attach test: Before: ``` 123: Test timeout computed to be: 1500 ``` Now: ``` $ echo 1 | sudo tee /proc/sys/kernel/yama/ptrace_scope; /usr/bin/time ctest -V -R client.attach_test; echo 0 | sudo tee /proc/sys/kernel/yama/ptrace_scope ... Start 121: code_api|client.attach_test ... 121: Test timeout computed to be: 90 1/1 Test #121: code_api|client.attach_test ......***Timeout 90.11 sec ... The following tests FAILED: 121 - code_api|client.attach_test (Timeout) ... Command exited with non-zero status 8 1.13user 0.80system 1:30.14elapsed 2%CPU (0avgtext+0avgdata 13196maxresident)k ``` Fixes #6127 Issue: #6127, #6558, #5740
derekbruening
added a commit
that referenced
this issue
Jan 16, 2024
Before, we relied on drrun -s for all test suite timeouts except for runcmp tests where we set a CTest timeout. This resulted in the default 10 minute CTest timeout for all tests, which was the only timeout for runall tests and caused long suite times on the AArch64 machine which accidentally had no ptrace privileges (#5740, #6558, Here, we set the CTest time for runall in addition to runcmp, and for all other tests with no timeout specified (which are presumably relying on drrun -s) we set a timeout of the drrun timeout plus 30 seconds. Tested on the attach test: Before: ``` 123: Test timeout computed to be: 1500 ``` Now: ``` $ echo 1 | sudo tee /proc/sys/kernel/yama/ptrace_scope; /usr/bin/time ctest -V -R client.attach_test; echo 0 | sudo tee /proc/sys/kernel/yama/ptrace_scope ... Start 121: code_api|client.attach_test ... 121: Test timeout computed to be: 90 1/1 Test #121: code_api|client.attach_test ......***Timeout 90.11 sec ... The following tests FAILED: 121 - code_api|client.attach_test (Timeout) ... Command exited with non-zero status 8 1.13user 0.80system 1:30.14elapsed 2%CPU (0avgtext+0avgdata 13196maxresident)k ``` The property being set on more tests was confirmed on debug x86-64: Before: ``` $ grep -c TIMEOUT suite/tests/CTestTestfile.cmake 94 ``` After: ``` $ grep -c TIMEOUT suite/tests/CTestTestfile.cmake 463 ``` There seem to still be a few missing the property: the ones that don't go through suite/. There were other efforts to avoid hangs on those such as PR #6137. Issue: #6127, #6558, #5740
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From [email protected] on April 13, 2009 00:22:22
lower-priority nice-to-have features to augment suite/runsuite.cmake:
Original issue: http://code.google.com/p/dynamorio/issues/detail?id=121
The text was updated successfully, but these errors were encountered: