i#2974 trace support for AArch64, part 14: Adding comments on

optimisation Issues: #1569, #2974
DynamoRIO · Sep 1, 2021 · ed826fd · ed826fd
1 parent 88c535d
commit ed826fd
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 0 deletions.
diff --git a/core/arch/arch_exports.h b/core/arch/arch_exports.h
@@ -2196,6 +2196,10 @@ int
 append_trace_speculate_last_ibl(dcontext_t *dcontext, instrlist_t *trace,
                                 app_pc speculate_next_tag, bool record_translation);
 
+
+/* XXX i#5062 In the long term we should have this only called in mangle_trace()
+ * and it should be removed from here.
+ */
 #ifdef AARCH64
 int
 fixup_indirect_trace_exit(dcontext_t *dcontext, instrlist_t *trace);

diff --git a/core/arch/interp.c b/core/arch/interp.c
@@ -5420,6 +5420,7 @@ recreate_fragment_ilist(dcontext_t *dcontext, byte *pc,
             instrlist_destroy(dcontext, bb);
         }
 
+        /* XXX i#5062 In the future this call should be placed inside mangle_trace() */
         IF_AARCH64(fixup_indirect_trace_exit(dcontext, ilist));
 
         /* PR 214962: re-apply client changes, this time storing translation

diff --git a/core/monitor.c b/core/monitor.c
@@ -1205,6 +1205,8 @@ end_and_emit_trace(dcontext_t *dcontext, fragment_t *cur_f)
         target = opnd_get_pc(instr_get_target(last));
         md->emitted_size -= local_exit_stub_size(dcontext, target, md->trace_flags);
     }
+
+    /* XXX i#5062 In the future this call should be placed inside mangle_trace() */
     IF_AARCH64(md->emitted_size += fixup_indirect_trace_exit(dcontext, trace));
 
     if (DYNAMO_OPTION(speculate_last_exit)