Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

in frontend, check for execute not read of DR root dir #2051

Closed
derekbruening opened this issue Sep 27, 2017 · 0 comments · Fixed by #2389
Closed

in frontend, check for execute not read of DR root dir #2051

derekbruening opened this issue Sep 27, 2017 · 0 comments · Fixed by #2389
Labels
Component-UI good first issue help wanted Priority-Low

Comments

@derekbruening
Copy link
Contributor

Today the Dr. Memory frontend does this check:

if (!file_is_readable(dr_root)) {
       fatal("invalid -dr_root %s", dr_root);

That's a directory, so it should really only check for +x, not +r. That allows an installer to prevent list access and only allow traversal.
jwysowski pushed a commit to jwysowski/drmemory that referenced this issue Mar 8, 2021
i#2051: in frontend, check for execute not read of DR root dir
62698ee 
Adds a new static function file_is_executable in frontend.c

Fixes DynamoRIO#2051
@jwysowski jwysowski mentioned this issue Mar 8, 2021
Merged
johnfxgalea pushed a commit that referenced this issue Mar 10, 2021
@jwysowski
i#2051: in frontend, check for execute not read of DR root dir (#2389)
a8c9721 
Adds a new static function file_is_executable in frontend.c to check for execute not read of DR root dir.

Fixes #2051
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component-UI good first issue help wanted Priority-Low
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

i#2051: in frontend, check for execute not read of DR root dir jwysowski/drmemory
1 participant
@derekbruening