Update pipeline.yml for new Artifactory url #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QilongTang
reviewed
Sep 18, 2019
|
Hi @QilongTang, @mjkkirschner and @pinzart90, We already have a new docker image, can you help us validate this pull request to do some test? |
|
@jesusHCG I am going to merge and request you test on the VM if that is OK, let me know! |
pinzart90
reviewed
Sep 20, 2019
| nodejs_version: "10" | ||
|
|
||
| build: | ||
| customized_builder_image: | ||
| registry: artifactory | ||
| url: autodesk-docker.art-bobcat.autodesk.com/quantum/hardened-nodejs:latest | ||
| url: artifactory.dev.adskengineer.net/docker-local-v2/docker-local-v2/dynamo/dynamolibrariejs:latest |
There was a problem hiding this comment.
What's up with the path to the image ?
/docker-local-v2/docker-local-v2
@jesusHCG @mjkkirschner ?
seems like this works too artifactory.dev.adskengineer.net/docker-local-v2/dynamo/dynamolibrariejs
There was a problem hiding this comment.
i used the url from the artifactory
QilongTang
added a commit
that referenced
this pull request
Mar 12, 2020
* Fix tests (#124) * Fix test * Update README.md * Forcing version by package.json * Add pipeline to run test in docker image. (#125) * Add pipeline to run test in docker image. * Create .npmrc * Update README.md * Update README.md * Update README.md * Update package.json * Update package.json * Update Jenkinsfile * Slack notification and docker suport (#126) * Delete duplicate folder (#127) * Add missing files * Delete indent-arrow-down-wo-lines.svg * Delete indent-arrow-right-wo-lines.svg * Delete plus-symbol.svg * Update package.json (#128) * Update pipeline.yml for new Artifactory url (#129) * Update package.json * Update pipeline.yml * Update pipeline.yml * Update pipeline.yml * Update pipeline.yml * Update pipeline.yml * Update pipeline.yml * New docker image * Add of csproj file for nuget packing (#130) * add of csproj file for nuget packing * New sources for dotnet pack * Update pipeline.yml * Update pipeline.yml * Update pipeline.yml * Update librariejs.csproj * Update librariejs.csproj * Update librariejs.csproj * Change name of project * new NUGET_API_ID (#131) * CI to switch to use stable branch (#136) * Create .sonarcloud.properties * Trident web browser control compat (#133) * cache the old url when the image fails to load - we need to be able to look it up later to reload the correct image. add core-js for ie polyfills (startsWith) - we can try just using a polyfill for that method only later. add core-js to entrypoint so its imported * remove discarded changes for extra event * Changes to use cbp/stable branch for the librariejs * Changes to use the CI Lib using the credential feature Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: Michael Kirschner <[email protected]> * Change of credential ID to use custom docker image (#137) * Develop (#139) * Change of credential ID to use custom docker image * Remove additional line of nprmc Co-authored-by: jesusHCG <[email protected]> Co-authored-by: manuelsaldivar525 <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: Michael Kirschner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change of Artifactory url and docker image
Related GitHub issue or JIRA story
https://jira.autodesk.com/browse/DYN-2071
https://jira.autodesk.com/browse/DYN-2072
Checklist