[DYN-4517] TuneUp will fail to register if not closed between graph runs #43
Conversation
builds without errors
now loads in all versions from the Extensions menu
- TuneUp active only when MenuItem.IsChecked - switches to manual model when activated - ViewModel.IsTuneUpChecked tracks MenuItem.IsChecked
TuneUp/TuneUpViewExtension.cs
Outdated
| // When _Extensions is specified, TuneUpMenuItem goes to the View menu in Dynamo 3.0- | ||
| // and does not appear in Dynamo 3.1+. | ||
| // We need to specify _View for TuneUpMenuItem to be added to the Extensions menu | ||
| var extensionsMenuItem = dynamoMenuItems.Where(item => item.Header.ToString() == "_View"); |
There was a problem hiding this comment.
Confused by this a bit.. we specify _View to be added to Extentions munue?
There was a problem hiding this comment.
You and me, brother 😁
I could not figure out why that is, might have to do with the way Dynamo loads the menus. Looking and the old master seem like this hasn't worked before either. In old demos Show TuneUp is always called from the View menu although the code was specifying _Extensions. I thought this is decent workaround for the time being as it's not a part of the ticket.
There was a problem hiding this comment.
Two things:
- Thank you Ivo for shifting it to Extensions. This is 100% where it should live!
- We should make sure the coat is hardened, so if there is a proper way to do it please refactor :)
aligned to .csproj & .props in master
|
@ivaylo-matov there are still 2 conflicts. |
…ot-closed-between-graph-runs
|
@reddyashish , sorry. Tried to resolve them before a couple of times, but wasn't sure if I should Commit Merge. |
|
LGTM. Thank you @ivaylo-matov. |
|
@QilongTang Will open a new PR to publish the tuneup package. |
PR aims to address https://jira.autodesk.com/browse/DYN-4517.
It also addresses 1. of https://autodesk.slack.com/archives/CPJ5UQW0Z/p1719284511762389 : TuneUp to not impact performance when not being actively used.
FYI
@QilongTang
@Ashish Ganta
@Amoursol