Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify webpack mode production in build script #3

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Specify webpack mode production in build script #3

merged 1 commit into from
Oct 5, 2022

Conversation

avidit
Copy link
Contributor

@avidit avidit commented Oct 5, 2022

No description provided.

@avidit avidit requested a review from QilongTang October 5, 2022 15:27
@QilongTang
Copy link
Contributor

@avidit Have you checked the prod build size? FYI: @filipeotero

@avidit
Copy link
Contributor Author

avidit commented Oct 5, 2022

@avidit Have you checked the prod build size? FYI: @filipeotero

I believe it was around 840 KiB

@QilongTang
Copy link
Contributor

Cool, I will merge and ask @filipeotero to give it a try. I suspect we were missing the production mode specification before

@QilongTang QilongTang merged commit d241443 into DynamoDS:master Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QilongTang QilongTang QilongTang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avidit @QilongTang