Dyn 5358 user friendly splash screen #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QilongTang
reviewed
Nov 7, 2022
QilongTang
approved these changes
Nov 7, 2022
avidit
reviewed
Nov 7, 2022
| this.setState({ signInStatus: ret }); | ||
| this.setState({ signInTitle: 'Signing In' }); | ||
| var ret2 = await chrome.webview.hostObjects.scriptObject.SignIn(); | ||
| this.setState({ signInStatus: ret2 }); | ||
|
|
||
| btn.classList.remove('disableButton'); | ||
| btn.disabled = false; | ||
| if (ret) { |
There was a problem hiding this comment.
Does ret needs to be renamed to ret2 here as well?
There was a problem hiding this comment.
I've changed the name because eslint was giving errors. It was changed to status, a better term. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following improvements for a more user friendly splash screen:
FYI: @QilongTang @avidit