Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code coverage #10

Merged
merged 11 commits into from
Oct 13, 2022
Merged

Add code coverage #10

merged 11 commits into from
Oct 13, 2022

Conversation

avidit
Copy link
Contributor

@avidit avidit commented Oct 13, 2022

No description provided.

@avidit avidit requested a review from QilongTang October 13, 2022 15:31
@QilongTang
Copy link
Contributor

@avidit Can you check the build error?

@avidit
Copy link
Contributor Author

avidit commented Oct 13, 2022

@avidit Can you check the build error?

The action is trying to comment the PR with the code coverage summary. It seems it can't access the github-token. Can you please check if we have it enabled?
Or we can also skip the PR comment part
https://github.com/zgosalvez/github-actions-report-lcov#usage

@QilongTang
Copy link
Contributor

QilongTang commented Oct 13, 2022 •
edited
Loading

@avidit Can you check the build error?

The action is trying to comment the PR with the code coverage summary. It seems it can't access the github-token. Can you please check if we have it enabled? Or we can also skip the PR comment part https://github.com/zgosalvez/github-actions-report-lcov#usage

I believe you need to set the github-token, we have a dynamo-ci bot I remember, maybe we need to set the token from that account so that bot user can comment

@avidit
Copy link
Contributor Author

avidit commented Oct 13, 2022

@avidit Can you check the build error?

The action is trying to comment the PR with the code coverage summary. It seems it can't access the github-token. Can you please check if we have it enabled? Or we can also skip the PR comment part zgosalvez/github-actions-report-lcov#usage

I believe you need to set the github-token, we have a dynamo-ci bot I remember, maybe we need to set the token from that account so that bot user can comment

I have removed the PR comment part for now.

@QilongTang QilongTang merged commit 6811051 into DynamoDS:master Oct 13, 2022
@avidit avidit deleted the feature/coverage branch October 14, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QilongTang QilongTang QilongTang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avidit @QilongTang