-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splash screen containing the loading bar #1
Splash screen containing the loading bar #1
Conversation
@filipeotero we'll need to change that image out as that is a Revit image :) Let me take a look to see if we have a better one from Dynamo itself. |
Any chance to load the image from a shared place like a S3 bucket so it could be changed it easily ? |
That's a good idea. What do you think? @zeusongit |
I actually think we do not want to do that. That would means when user is offline, they would not see the image at all from our splash screen which is not a common experience for other ADSK products. Since the splash screen is the first thing user see in Dynamo, I do not want to make any comprimise yet in similar user case even offline. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good progres, some comments
@filipeotero I would like to also consult you with the font, is it embedded currently in the css file? What is the font? |
adjusting the path to the build in the gitignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once rest of the comments addressed and also the image from @Amoursol updated
@QilongTang I created a method called |
Thanks, this should give us more flexibility |
I think this is good as a first version to get in. @filipeotero Let me know if you plan to actually replaced the encoded image in this repo before merging |
Image replaced: |
This PR contains the design implementation for the dynamic splash as described on the splash screen Wiki page:
https://wiki.autodesk.com/display/GEN/Dynamo+splash+screen
For the implementation of the grid, I have installed the bootstrap package that makes the stylization more simple.
https://react-bootstrap.github.io/layout/grid/
Here is an example of how it works by inputting some data by calling a method from outside the web app.
Also, for this example, I created a sandbox WPF containing a popup to simulate how it's going to work in Dynamo.
FYI: @QilongTang @reddyashish @zeusongit @RobertGlobant20 @jesusalvino