Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splash screen containing the loading bar #1

Merged

Conversation

filipeotero
Copy link
Contributor

@filipeotero filipeotero commented Sep 21, 2022

This PR contains the design implementation for the dynamic splash as described on the splash screen Wiki page:
https://wiki.autodesk.com/display/GEN/Dynamo+splash+screen

For the implementation of the grid, I have installed the bootstrap package that makes the stylization more simple.
https://react-bootstrap.github.io/layout/grid/

Here is an example of how it works by inputting some data by calling a method from outside the web app.
Also, for this example, I created a sandbox WPF containing a popup to simulate how it's going to work in Dynamo.

dynamicSplashScreen

FYI: @QilongTang @reddyashish @zeusongit @RobertGlobant20 @jesusalvino

package.json Outdated Show resolved Hide resolved
src/App.js Outdated Show resolved Hide resolved
@Amoursol
Copy link
Contributor

@filipeotero we'll need to change that image out as that is a Revit image :) Let me take a look to see if we have a better one from Dynamo itself.

@jesusalvino
Copy link
Contributor

Any chance to load the image from a shared place like a S3 bucket so it could be changed it easily ?

@filipeotero
Copy link
Contributor Author

Any chance to load the image from a shared place like a S3 bucket so it could be changed it easily ?

That's a good idea. What do you think? @zeusongit

@QilongTang
Copy link
Contributor

Any chance to load the image from a shared place like a S3 bucket so it could be changed it easily ?

That's a good idea. What do you think? @zeusongit

I actually think we do not want to do that. That would means when user is offline, they would not see the image at all from our splash screen which is not a common experience for other ADSK products. Since the splash screen is the first thing user see in Dynamo, I do not want to make any comprimise yet in similar user case even offline.

.gitignore Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/App.js Outdated Show resolved Hide resolved
Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progres, some comments

@QilongTang
Copy link
Contributor

@filipeotero I would like to also consult you with the font, is it embedded currently in the css file? What is the font?

Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once rest of the comments addressed and also the image from @Amoursol updated

src/App.js Outdated Show resolved Hide resolved
@filipeotero
Copy link
Contributor Author

Any chance to load the image from a shared place like a S3 bucket so it could be changed it easily ?

That's a good idea. What do you think? @zeusongit

I actually think we do not want to do that. That would means when user is offline, they would not see the image at all from our splash screen which is not a common experience for other ADSK products. Since the splash screen is the first thing user see in Dynamo, I do not want to make any comprimise yet in similar user case even offline.

@QilongTang I created a method called setBackgroundImage with a keyword "#base64BackgroundImage" that can be replaced when we read the files on the Dynamo side.

@QilongTang
Copy link
Contributor

Any chance to load the image from a shared place like a S3 bucket so it could be changed it easily ?

That's a good idea. What do you think? @zeusongit

I actually think we do not want to do that. That would means when user is offline, they would not see the image at all from our splash screen which is not a common experience for other ADSK products. Since the splash screen is the first thing user see in Dynamo, I do not want to make any comprimise yet in similar user case even offline.

@QilongTang I created a method called setBackgroundImage with a keyword "#base64BackgroundImage" that can be replaced when we read the files on the Dynamo side.

Thanks, this should give us more flexibility

@QilongTang
Copy link
Contributor

I think this is good as a first version to get in. @filipeotero Let me know if you plan to actually replaced the encoded image in this repo before merging

@filipeotero
Copy link
Contributor Author

I think this is good as a first version to get in. @filipeotero Let me know if you plan to actually replaced the encoded image in this repo before merging

Image replaced:

image (2)

@QilongTang QilongTang merged commit 1b3c21e into DynamoDS:master Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants