Set13| Add Node Documentation for...(Documentation Added: 60 nodes) #3126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: PrlxAaronMaller <[email protected]> Co-Authored-By: l-schmidt <[email protected]>
johnpierson
force-pushed
the
johnPierson_nodeDocumentation_Set13
branch
from
39d5d1f to
05b322d
Compare
emru-y
approved these changes
Jan 9, 2025
emru-y
reviewed
Jan 9, 2025
emru-y
reviewed
Jan 9, 2025
emru-y
approved these changes
Jan 9, 2025
emru-y
approved these changes
Jan 9, 2025
emru-y
approved these changes
Jan 9, 2025
emru-y
approved these changes
Jan 9, 2025
emru-y
approved these changes
Jan 9, 2025
emru-y
approved these changes
Jan 9, 2025
emru-y
approved these changes
Jan 9, 2025
emru-y
approved these changes
Jan 9, 2025
emru-y
approved these changes
Jan 9, 2025
emru-y
approved these changes
Jan 9, 2025
emru-y
reviewed
Jan 9, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
emru-y
approved these changes
Jan 9, 2025
emru-y
approved these changes
Jan 9, 2025
emru-y
requested changes
Jan 9, 2025
There was a problem hiding this comment.
Completed the review. It looks great! There are some minor changes that needs to be done before the merge.
I would appreciate if we can prioritize these changes and merge the PR as soon as possible since there is not so much time left for other teams to work on them for the scope of Revit 2026.
Thank you very much for your support on this!
doc/distrib/NodeHelpFiles/_review/DSRevitNodesUI.FillPatterns.md
Outdated
Show resolved
Hide resolved
doc/distrib/NodeHelpFiles/_review/DSRevitNodesUI.FillPatternTargets.md
Outdated
Show resolved
Hide resolved
doc/distrib/NodeHelpFiles/_review/Revit.Elements.FillPatternElement.GetByName.md
Outdated
Show resolved
Hide resolved
doc/distrib/NodeHelpFiles/_review/Revit.Elements.LinkInstance.ElementById.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Can we show the result of the last node as other samples and update this file?
doc/distrib/NodeHelpFiles/_review/Revit.Elements.TextNote.SetHorizontalAlignment.md
Outdated
Show resolved
Hide resolved
doc/distrib/NodeHelpFiles/_review/Revit.Elements.TextNote.SetKeepRotatedTextReadable.md
Outdated
Show resolved
Hide resolved
doc/distrib/NodeHelpFiles/_review/Revit.Elements.Views.CeilingPlanView.ByLevel.md
Outdated
Show resolved
Hide resolved
doc/distrib/NodeHelpFiles/_review/Revit.Elements.Views.FloorPlanView.ByLevel.md
Outdated
Show resolved
Hide resolved
doc/distrib/NodeHelpFiles/_review/Revit.Transaction.Transaction.End.md
Outdated
Show resolved
Hide resolved
emru-y
approved these changes
Jan 15, 2025
|
Awesome, let me move the stuff to the right folder |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Final PR for this quarter.
Declarations
DSRevitNodesUI.FillPatterns.dyn
DSRevitNodesUI.FillPatternTargets.dyn
DSRevitNodesUI.HorizontalAlignment.dyn
DSRevitNodesUI.LinePatterns.dyn
DSRevitNodesUI.VerticalAlignment.dyn
Revit.Application.Document.IsCloudPath.dyn
Revit.Application.Document.WorksharingPath.dyn
Revit.Elements.CeilingType.ByName.dyn
Revit.Elements.CeilingType.GetThermalProperties.dyn
Revit.Elements.CeilingType.Name.dyn
Revit.Elements.Coordinates.BasePoint.dyn
Revit.Elements.Coordinates.ProjectRotation.dyn
Revit.Elements.Coordinates.SurveyPoint.dyn
Revit.Elements.DirectShape.ByGeometry.dyn
Revit.Elements.FamilyInstance.ByCoordinates.dyn
Revit.Elements.FamilyInstance.ByFamilyType.dyn
Revit.Elements.FilledRegionType.ByName.dyn
Revit.Elements.FilledRegionType.Name.dyn
Revit.Elements.FillPatternElement.GetByName.dyn
Revit.Elements.Floor.Points.dyn
Revit.Elements.LinePatternElement.GetByName.dyn
Revit.Elements.LinkElement.BoundingBox.dyn
Revit.Elements.LinkInstance.AllElementsOfClass.dyn
Revit.Elements.LinkInstance.ByName.dyn
Revit.Elements.LinkInstance.ElementById.dyn
Revit.Elements.Material.AppearanceParameters.dyn
Revit.Elements.Material.MaterialCategory.dyn
Revit.Elements.Material.StructuralParameters.dyn
Revit.Elements.Material.ThermalParameters.dyn
Revit.Elements.PathOfTravel.ByFloorPlanPoints.dyn
Revit.Elements.ReferencePoint.ByCoordinates.dyn
Revit.Elements.ReferencePoint.ByParametersOnFaceReference.dyn
Revit.Elements.ReferencePoint.ByPoint.dyn
Revit.Elements.ReferencePoint.Point.dyn
Revit.Elements.ReferencePoint.X.dyn
Revit.Elements.ReferencePoint.XYPlane.dyn
Revit.Elements.ReferencePoint.XZPlane.dyn
Revit.Elements.ReferencePoint.Y.dyn
Revit.Elements.ReferencePoint.YZPlane.dyn
Revit.Elements.ReferencePoint.Z.dyn
Revit.Elements.RoofType.ByName.dyn
Revit.Elements.RoofType.GetThermalProperties.dyn
Revit.Elements.RoofType.Name.dyn
Revit.Elements.Room.IsInsideRoom.dyn
Revit.Elements.Tag.ByElement.dyn
Revit.Elements.Tag.GetLeaderEndCondition.dyn
Revit.Elements.Tag.SetLeaderEndCondition.dyn
Revit.Elements.TextNote.SetHorizontalAlignment.dyn
Revit.Elements.TextNote.SetKeepRotatedTextReadable.dyn
Revit.Elements.TextNoteType.Default.dyn
Revit.Elements.Toposolid.ByOutlinePointsTypeAndLevel.dyn
Revit.Elements.Toposolid.Points.dyn
Revit.Elements.Views.CeilingPlanView.ByLevel.dyn
Revit.Elements.Views.FloorPlanView.ByLevel.dyn
Revit.Elements.Views.View.SetCategoryOverrides.dyn
Revit.Elements.Views.View.SetCropBoxActive.dyn
Revit.Elements.Wall.ByFace.dyn
Revit.Filter.OverrideGraphicSettings.ByProperties.dyn
Revit.Transaction.Transaction.End.dyn
Toposolid.ByOutlinePointsTypeAndLevel(outline, points, toposolidType, level).dyn
Check these if you believe they are true
*.resxfilesReviewers
@emru-y
FYIs
@Amoursol
@achintyabhat
Since this goes over the holidays, any review comments or modification requests after December 31st, 2024 will have to go to Parallax Team (@PrlxAaronMaller or @l-schmidt)