-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set03| Add Node Documentation for...(Documentation Added: 12 nodes) #3089
Set03| Add Node Documentation for...(Documentation Added: 12 nodes) #3089
Conversation
doc/distrib/NodeHelpFiles/_review/Revit.Elements.Element.Curves_img.jpg
Outdated
Show resolved
Hide resolved
doc/distrib/NodeHelpFiles/_review/Revit.Elements.Element.Faces.dyn
Outdated
Show resolved
Hide resolved
doc/distrib/NodeHelpFiles/_review/Revit.Elements.Element.Faces_img.jpg
Outdated
Show resolved
Hide resolved
doc/distrib/NodeHelpFiles/_review/Revit.Elements.Element.Solids.dyn
Outdated
Show resolved
Hide resolved
doc/distrib/NodeHelpFiles/_review/Revit.Elements.Element.Solids.md
Outdated
Show resolved
Hide resolved
doc/distrib/NodeHelpFiles/_review/Revit.Elements.Element.Solids_img.jpg
Outdated
Show resolved
Hide resolved
doc/distrib/NodeHelpFiles/_review/Revit.Elements.Parameter.GroupType.md
Outdated
Show resolved
Hide resolved
doc/distrib/NodeHelpFiles/_review/Revit.Elements.Parameter.ParameterByName.dyn
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick note, so we don't forget this-If the List.FirstItem node is removed from the example file, the image needs to be updated as well.
doc/distrib/NodeHelpFiles/_review/Revit.Elements.Parameter.SetValue.dyn
Outdated
Show resolved
Hide resolved
doc/distrib/NodeHelpFiles/_review/Revit.Elements.Parameter.SetValue_img.jpg
Outdated
Show resolved
Hide resolved
doc/distrib/NodeHelpFiles/_review/Revit.Elements.Parameter.SpecType.dyn
Outdated
Show resolved
Hide resolved
doc/distrib/NodeHelpFiles/_review/Revit.Elements.Parameter.SpecType_img.jpg
Outdated
Show resolved
Hide resolved
doc/distrib/NodeHelpFiles/_review/Revit.Elements.Parameter.StorageType.dyn
Outdated
Show resolved
Hide resolved
doc/distrib/NodeHelpFiles/_review/Revit.Elements.Parameter.StorageType_img.jpg
Outdated
Show resolved
Hide resolved
doc/distrib/NodeHelpFiles/_review/Revit.Elements.Parameter.Value.dyn
Outdated
Show resolved
Hide resolved
doc/distrib/NodeHelpFiles/_review/Revit.Elements.Parameter.Value_img.jpg
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might look like a lot of comments-but a generic theme in this set. You will see a recurring comment here. I wasn't quite sure why the First Item from the list is needed? Gives a wrong impression that the node cannot have a list of elements as input. Also, Two of the images are hard to read without zooming in. But other than that, as always thanks for the great examples and the notes for additional context where needed!
Thanks so much @achintyabhat , I am not too sure why I had the first item node in there. lol All comments are addressed now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @johnpierson for the updates. This looks great!
Purpose
Add node documentation for:
"Element/ Family/Parameters Creation & Modification"
Parameter.GroupType
Parameter.ParameterByName
Parameter.SetValue
Parameter.SpecType
Parameter.StorageType
Parameter.Value
Element.IsPinned
Element.GetCategory
Element.GetHostedElements
Element.Faces
Element.Solids
Element.Curves
Declarations
Check these if you believe they are true
*.resx
filesReviewers
@achintyabhat
FYIs
@Amoursol