Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set03| Add Node Documentation for...(Documentation Added: 12 nodes) #3089

Merged

Conversation

johnpierson
Copy link
Member

@johnpierson johnpierson commented Aug 28, 2024

Purpose

Add node documentation for:

"Element/ Family/Parameters Creation & Modification"

Parameter.GroupType
Parameter.ParameterByName
Parameter.SetValue
Parameter.SpecType
Parameter.StorageType
Parameter.Value
Element.IsPinned
Element.GetCategory
Element.GetHostedElements
Element.Faces
Element.Solids
Element.Curves

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • Snapshot of UI changes, if any.

Reviewers

@achintyabhat

FYIs

@Amoursol

@johnpierson johnpierson marked this pull request as ready for review August 28, 2024 19:46

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick note, so we don't forget this-If the List.FirstItem node is removed from the example file, the image needs to be updated as well.

Copy link

@achintyabhat achintyabhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might look like a lot of comments-but a generic theme in this set. You will see a recurring comment here. I wasn't quite sure why the First Item from the list is needed? Gives a wrong impression that the node cannot have a list of elements as input. Also, Two of the images are hard to read without zooming in. But other than that, as always thanks for the great examples and the notes for additional context where needed!

@johnpierson
Copy link
Member Author

Thanks so much @achintyabhat , I am not too sure why I had the first item node in there. lol

All comments are addressed now!

Copy link

@achintyabhat achintyabhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @johnpierson for the updates. This looks great!

@johnpierson johnpierson merged commit f740bdd into DynamoDS:master Sep 3, 2024
9 checks passed
@johnpierson johnpierson changed the title Set03| Add Node Documentation for... Set03| Add Node Documentation for...(Documentation Added: 12 nodes) Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants