-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dyn-6672 - python engines failing to load should not stop Dynamo from starting #3040
Conversation
@@ -147,7 +147,6 @@ | |||
</Reference> | |||
</ItemGroup> | |||
<ItemGroup> | |||
<Content Include="Ionic.Zip.xml" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file was deleted previously.
catch(FileNotFoundException ex) | ||
{ | ||
Logger.Log(ex); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really wish there was a DynamoCore way to ensure that all PythonEngine public APIs are safe to use
If we go with this route, I think we might have to do the same thing for other host integrators
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You cannot even mark an event as "Can throw Exception of type X". Oh we can...if that is any comfort
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pinzart90 I am looking into something on the DynamoCore side, I will send another PR for feedback on that. More a spike than something real at this point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to propagate the error in DynamoCore and display it to the user somehow?
Purpose
DynamoDS/Dynamo#14891
Declarations
Check these if you believe they are true
*.resx
files