-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dependencies #3028
base: master
Are you sure you want to change the base?
update dependencies #3028
Conversation
@@ -160,4 +95,17 @@ | |||
<ItemGroup> | |||
<Compile Remove="RevitSettings.cs" /> | |||
</ItemGroup> | |||
<ItemGroup> | |||
<PackageReference Include="DynamoVisualProgramming.Core" Version="3.0.0.7190" ExcludeAssets="runtime" GeneratePathProperty="true" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice.
<HintPath Condition=" Exists('$(DYNAMOBUILDPATH)')">$(DYNAMOBUILDPATH)\DynamoCoreWpf.dll</HintPath> | ||
<Private>False</Private> | ||
</Reference> | ||
<PackageReference Include="DynamoVisualProgramming.Tests" Version="0.0.1" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.0.1? wasn't this 1.0.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ugh..I was testing it locally. Will update the version
</ItemGroup> | ||
<Target Name="Copy dll" AfterTargets="Build"> | ||
<ItemGroup> | ||
<DetectiveDll Include="$(PkgDynamoVisualProgramming_Core)\lib\net8.0\DynamoInstallDetective.dll" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why doesn't this automatically get copied to the output path using EnableDynamicLoading
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this project is referencing other projects that already include the necessary packagereferences?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these changes eliminate the need for packages.aget, etc. and restorepackages.bat
?
Switch to package references
Update versions