Update to Dynamo Core 2.8 #2608
Conversation
Includes: - Dynamo NuGet update - Preloading the Dynamo CPython3 engine - Revit customizations for Dynamo CPython3 engine Known caveats: - No tests for new Python engine - Dynamo Core is no longer CLS-compliant creating hundreds of warnings - Dynamo NuGets for 2.8 are still in beta
|
Any idea when / how we lost CLS compliance? Not that this is particularly important IMO... but we may want to silence those. |
|
Yes, it was here DynamoDS/Dynamo#10668. I was told by @QilongTang this was resolved as a way to silence SQ warnings. I was trying to see if we had other ways of dealing with this, maybe silencing the warnings in SQ itself or something like that. |
|
@mjkkirschner Was discussed in slack when first time we tackle SQ warnings, according to SQ we are not really following CLS compliant rules so less meaningful to keep that setting. Let me know. |
|
oh, I see, perhaps it would be appropriate to add a pragma to DynamoRevit disabling the warnings if we have no intention of being CLS compliant - I know in some cases we can't - because we can't change API names at this time. |
| <Private>False</Private> | ||
| </Reference> | ||
| <Reference Include="Python.Runtime"> | ||
| <HintPath>$(PACKAGESPATH)\pythonnet\lib\net40\Python.Runtime.dll</HintPath> |
There was a problem hiding this comment.
what was this actually needed for?
There was a problem hiding this comment.
A reference to PyScope is required when adding the UnwrapElement function.
|
Hi @mjkkirschner @QilongTang , @AndyDu1985 is on vacation now, and I should confirm whether we want to upgrade to DynamoCore 2.8.0 now and will be released next version. |
|
@ZiyunShang Is there a way we can get Dynamo 2.8 on Revit master branch? I think this PR is the suggested work |
| CPythonEvaluator.EvaluationEnd += (a, b, c, d) => ElementBinder.IsEnabled = true; | ||
|
|
||
| // register UnwrapElement method in cpython | ||
| CPythonEvaluator.EvaluationBegin += (a, scope, c, d) => |
There was a problem hiding this comment.
should we be unsubscribing these when python nodes are removed from the workspace?
There was a problem hiding this comment.
I didn't get that @mjkkirschner . These events are static, not really associated to a Python node in particular.
|
@AndyDu1985 @ZiyunShang Is it fine to merge now or you would rather wait for the final RC2.8.0 to be out by end of month to do a single sweep? |
It's OK have this version in DynamoRevit. |
This reverts commit 65e2e52.
Purpose
Includes:
Known caveats:
Declarations
Check these if you believe they are true
*.resxfilesReviewers
FYIs
@mjkkirschner @QilongTang