Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing test cases #1601

Merged
merged 3 commits into from
Mar 6, 2017
Merged

Fix failing test cases #1601

merged 3 commits into from
Mar 6, 2017

Conversation

Randy-Ma
Copy link
Contributor

@Randy-Ma Randy-Ma commented Mar 6, 2017

Purpose

Recently there are three test cases which are failing:

  • Level
  • RoomProperties
  • DividedCurve

The two test cases - Level and DividedCurve are failing because the change in the number node. (Refer details in the pull request: DynamoDS/Dynamo#7582). @ikeough, the test cases are failing because "0..1...1" and "0..20..2" are not supported in the new number node any more. I have just updated the related test cases to fix the issue.

The other test case - RoomProperties is a newly added test case. I do not think it is proper to just compare two doubles 12.869999999999999d and 12.87 without considering tolerance. I am updating the test case to compare in a tolerance of 1e-9.

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • Snapshot of UI changes, if any.

FYIs

@ikeough @kronz

@Randy-Ma
Copy link
Contributor Author

Randy-Ma commented Mar 6, 2017

@ikeough @kronz
I am merging this given this is breaking the build. If you have any comments, I will address them later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants