Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Recently there are three test cases which are failing:
The two test cases - Level and DividedCurve are failing because the change in the number node. (Refer details in the pull request: DynamoDS/Dynamo#7582). @ikeough, the test cases are failing because "0..1...1" and "0..20..2" are not supported in the new number node any more. I have just updated the related test cases to fix the issue.
The other test case - RoomProperties is a newly added test case. I do not think it is proper to just compare two doubles 12.869999999999999d and 12.87 without considering tolerance. I am updating the test case to compare in a tolerance of 1e-9.
Declarations
Check these if you believe they are true
*.resx
filesFYIs
@ikeough @kronz