-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DynamoRevit 2.x Categories Dropdown Produces Inconsistent Results Between Revit versions #2281
Comments
@dimven Good suggestion! @AndyDu1985 @ZiyunShang @BogdanZavu @sm6srw Looking for your suggestion here, let's assume the index for all categories will always change, should we override the category dropdown to serialize the category name or element id whichever is more stable? |
@andydandy74 just pointed out to me that this is a regression: |
Category name is not going to work across revit localizations. Use built in category name instead. |
By the way - the |
@QilongTang Yes, as far as Categories go, the stable thing is the built-in ID and this is what should be serialized. |
It is worse than just "inconsistent between versions". It is impossible now to even localize scripts for the same version, as lists are sorted in each language, so the index means nothing. |
Closing. This should be fixed in the coming DynamoCore + DynamoRevit 2.1.0 release. |
If this issue is not a bug report or improvement request, please check the Dynamo forum, and start a thread there to discuss your issue.
Dynamo version
2.x
Revit version
Any two recent versions of Revit, e.g. 2018 and 2019
Operating system
Windows 10
What did you do?
Steps to reproduce:
What did you expect to see?
The exact same category selection between versions
What did you see instead?
Something else
This happens because the dropdown is serialized as just and index integer in the JSON, where as built-in categories are not static between Revit versions.
I imagine one way to solve this is to store the current selection as both a string and an index.
The text was updated successfully, but these errors were encountered: