Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dyn-6750-new-open-update #14

Merged
merged 2 commits into from
May 1, 2024
Merged

Dyn-6750-new-open-update #14

merged 2 commits into from
May 1, 2024

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Apr 26, 2024

Purpose

This PR addresses a jira request for improvement of the HomePage: As a Dynamo user, I would like to have New and Open buttons in app home to have default actions https://jira.autodesk.com/browse/DYN-6750.

By default, clicking on the button should perform the default action.
New -> New workspace
Open -> Open File

Only the dropdown should show other options
New ...

  • Workspace

Custom Node
Open ...

Open File
Open Template
Backup Locations
Also can shit New to the top top?

UI Changes

DynamoSandbox_qkOXGy4Uo6

Changes

  • now separates the 'button' from the 'drop-down' functionality of the 'Open' and 'New' HomePage buttons.
  • visual rehaul with @Jingyi-Wen
  • version bump

Reviewer

@QilongTang
@Amoursol

@QilongTang
Copy link
Collaborator

This one becomes hard to review because it contains changes in the other preferences PR..

@dnenov
Copy link
Collaborator Author

dnenov commented Apr 30, 2024

This one becomes hard to review because it contains changes in the other preferences PR..

Understood, Aaron - should I try to restructure it and remove the Preferences changes .. or wait to merge the Preferences PR and pull the latest main branch maybe?

@QilongTang
Copy link
Collaborator

This one becomes hard to review because it contains changes in the other preferences PR..

Understood, Aaron - should I try to restructure it and remove the Preferences changes .. or wait to merge the Preferences PR and pull the latest main branch maybe?

I would remove the preferences changes and keep it clean because this could land earlier than the other sets of PR

@dnenov dnenov force-pushed the DYN-6750-new-open-update branch from 6106599 to d90207a Compare May 1, 2024 05:49
@dnenov
Copy link
Collaborator Author

dnenov commented May 1, 2024

This one becomes hard to review because it contains changes in the other preferences PR..

Understood, Aaron - should I try to restructure it and remove the Preferences changes .. or wait to merge the Preferences PR and pull the latest main branch maybe?

I would remove the preferences changes and keep it clean because this could land earlier than the other sets of PR

Done, @QilongTang! Thanks for the pointers!!

@QilongTang QilongTang merged commit 5b6b90b into master May 1, 2024
11 checks passed
@QilongTang QilongTang deleted the DYN-6750-new-open-update branch May 1, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants