Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #26

Merged
merged 2 commits into from
Jul 23, 2020
Merged

Update README.md #26

merged 2 commits into from
Jul 23, 2020

Conversation

mmisol
Copy link
Collaborator

@mmisol mmisol commented Jul 23, 2020

Make clear Node 8 is required and provide help for common caveats.

@mmisol
Update README.md
8bebd04 
Make clear Node 8 is required and provide help for common caveats.
QilongTang
QilongTang reviewed Jul 23, 2020
View reviewed changes
Copy link

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any version of node 8 is good?

mjkkirschner
mjkkirschner approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@mjkkirschner mjkkirschner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we test this build on linux or windows as well?

@mmisol
Copy link
Collaborator Author

mmisol commented Jul 23, 2020

@QilongTang I would say so. Tried with v8.11.4 which is the one I had installed.

@mmisol
Copy link
Collaborator Author

mmisol commented Jul 23, 2020

@mjkkirschner I can give it a try in Windows too 👍

@mmisol
Remove VPN section
bf75dc2 
Not really needed. Must be something set up on my Mac
@mmisol
Copy link
Collaborator Author

mmisol commented Jul 23, 2020

Works on Windows too 👍 It actually helped me find out we don't really need VPN. Must be something I have set up on my Mac.

@mmisol mmisol merged commit 3366ab0 into DynamoDS:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QilongTang QilongTang QilongTang left review comments

@mjkkirschner mjkkirschner mjkkirschner approved these changes

@zeusongit zeusongit Awaiting requested review from zeusongit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmisol @mjkkirschner @QilongTang