Python script editor should provide a workspace ID when updating model #9988
Conversation
|
Need to add a test for #9479 and confirm that the API change to add a parameter to the internal method |
Dewb
changed the title
| @@ -47,8 +48,9 @@ public partial class ScriptEditorWindow : ModelessChildWindow | |||
| Dynamo.Logging.Analytics.TrackScreenView("Python"); | |||
| } | |||
|
|
|||
| internal void Initialize(Guid nodeGuid, string propName, string propValue) | |||
| internal void Initialize(Guid workspaceGuid, Guid nodeGuid, string propName, string propValue) | |||
There was a problem hiding this comment.
this should be fine as it's an internal method.
There was a problem hiding this comment.
The entire class probably ought to be internal instead of public, as it's not useful without being able to call the Initialize method.
There was a problem hiding this comment.
@Dewb In this case, can you make a comment to the class, e.g. TODO: Make this class internal in Dynamo 3.0? By the time we tackle it, we would remember to do this.
|
@Dewb this seems like a good crash fix, do need help finishing up the tests so that it might make it into 2.5? |
|
Tests are still blocked by the undo bug. Let's talk tomorrow about a strategy to get these both resolved. |
|
tracked with https://jira.autodesk.com/browse/DYN-2155 |
|
I believe this is ready to merge. |
|
@Dewb thanks! this looks good to me, we can take cherry picking this to 2.5 RC branch. |
DynamoDS#9988) * Python node should provide a workspace ID when calling UpdateModelValueCommand, fixing DynamoDS#9479 * Draft test for DynamoDS#9479 (not passing yet due to undo issues) * Disable section of python custom node save test that uses undo * Remove file added by accident * Fix null dereference in UpdateModelValueImpl (cherry picked from commit e775794)
#9988) (#10173) * Python node should provide a workspace ID when calling UpdateModelValueCommand, fixing #9479 * Draft test for #9479 (not passing yet due to undo issues) * Disable section of python custom node save test that uses undo * Remove file added by accident * Fix null dereference in UpdateModelValueImpl (cherry picked from commit e775794)
Purpose
The Python node's code editor sends an UpdateModelValueCommand with an empty workspace GUID, meaning the current workspace. Since the Python editor is no longer modal, this assumption (that the parent workspace is current) no longer holds. This change explicitly provides the workspace ID. This fixes #9479, avoiding a crash when a modeless Python node editor is opened from a custom node workspace and "Run" or "Save" is clicked while the home workspace is current.
Declarations
Check these if you believe they are true
*.resxfiles