Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to use public getter instead of private member #9966

Merged
merged 1 commit into from
Sep 9, 2019

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Sep 9, 2019

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

Some code refactor happened and removed the setting of private member. This PR fix the regression that publish current workspace command does not return anything.

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@mjkkirschner
Copy link
Member

@QilongTang thanks - is it difficult to add a test to assert this function does not throw?

@QilongTang
Copy link
Contributor Author

@mjkkirschner Unfortunately, publishing current workspace will always throw an exception no matter what. So assertion test does not help.

Side note: this reproduces in 2.3.0 as well.
Merging.
image

@aparajit-pratap
Copy link
Contributor

aparajit-pratap commented Sep 9, 2019

@QilongTang sorry that was me that made the change recently: ef55f1b#diff-87708e28021df7b325448575f92c8e69R189
which means this regression was probably caused by this PR: #9815 :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants