Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Down Vote Button and Obsolete UI command #9950

Merged
merged 2 commits into from
Sep 4, 2019

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Aug 29, 2019

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

DYN-1990
As a Dynamo dev, I want to clean up package down vote info to push positive reinforcement.

Before:
image

After:
image

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
    Running Self CI
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@DynamoDS/dynamo

FYIs

@Dewb @johnpierson @Amoursol

@@ -155,6 +156,7 @@ public void Upvote()
, TaskScheduler.FromCurrentSynchronizationContext());
}

[Obsolete("This API will no longer decrease package votes and will be removed in Dynamo 3.0")]
public void Downvote()
Copy link
Member

@mjkkirschner mjkkirschner Aug 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if someone calls this method - it should do nothing right? Will the continuation ever get called?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, since the handler of the DownvoteRequested event is removed, the call will do nothing and return nothing

@QilongTang
Copy link
Contributor Author

Self CI passed

@mjkkirschner
Copy link
Member

@QilongTang LGTM

@QilongTang QilongTang merged commit 2d265ed into master Sep 4, 2019
@QilongTang QilongTang deleted the RemoveDownVoteButton branch September 4, 2019 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants