Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-2002 Localize the node description tooltip. #9907

Merged
merged 3 commits into from
Aug 16, 2019

Conversation

reddyashish
Copy link
Contributor

@reddyashish reddyashish commented Aug 13, 2019

Purpose

This PR is in reference to this task: https://jira.autodesk.com/browse/DYN-2002.

In short after this fix, the description tooltip (for the nodes in the workspace) will be converted to the localized language. We will still be serializing this property but when deserializing we do not read this value from the JSON file. The value will be picked up from node's xml config and will be converted to the localized language.

Screen Shot 2019-08-13 at 12 24 21 PM

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@mjkkirschner @QilongTang @aparajit-pratap

@mjkkirschner
Copy link
Member

@reddyashish nice, can we also add a test for this?
The test can open a pre made .dyn file with a description set to "BADDESCRIPTION" or something like that - and then make sure the description of the loaded node is not set to that.

@reddyashish
Copy link
Contributor Author

reddyashish commented Aug 14, 2019

@mjkkirschner I have added the test. There are no failures on self-service but do you still think any of the existing tests have to be updated?

@reddyashish reddyashish merged commit 731aeb6 into DynamoDS:master Aug 16, 2019
reddyashish added a commit to reddyashish/Dynamo that referenced this pull request Aug 16, 2019
* DYN2002

* Adding comments.

* Adding test

(cherry picked from commit 731aeb6)
reddyashish added a commit that referenced this pull request Aug 16, 2019
…#9913)

* DYN-2002 Localize the node description tooltip. (#9907)

* DYN2002

* Adding comments.

* Adding test

(cherry picked from commit 731aeb6)

* Spacing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants