Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix localization for Spanish Civil 3D #9876

Merged
merged 2 commits into from
Aug 5, 2019
Merged

Fix localization for Spanish Civil 3D #9876

merged 2 commits into from
Aug 5, 2019

Conversation

angelowang
Copy link
Contributor

@angelowang angelowang commented Aug 5, 2019

In AutoCAD/Civil3D, CurrentUICulture.ToString() will return traditional es-ES_tradnl,
instead of plain es-ES. This will fail the finding of xml document, gallery, and sample folders later.

This change uses CurrentUICulture.Name instead.
From MS DOC for CultureInfo.Name:

Gets the culture name in the format languagecode2-country/regioncode2.

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

(FILL ME IN) This section describes why this PR is here. Usually it would include a reference
to the tracking task that it is part or all of the solution for.

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@DynamoDS/dynamo

FYIs

In AutoCAD/Civil3D, `CurrentUICulture.ToString()` will return traditional `es-ES_tradnl`,
instead of plain `es-ES`. This will fail the finding of xml document later.

This change uses `CurrentUICulture.Name` instead.
From MS DOC for `CultureInfo.Name`:
> Gets the culture name in the format languagecode2-country/regioncode2.
@angelowang angelowang changed the title Fix tooltip for Spanish Civil 3D Fix localization for Spanish Civil 3D Aug 5, 2019
@QilongTang QilongTang added the LGTM Looks good to me label Aug 5, 2019
@QilongTang
Copy link
Contributor

@angelowang Thank you, LGTM, will merge and run tests on it

@QilongTang QilongTang merged commit ddbf7e3 into DynamoDS:RC2.4.0_master Aug 5, 2019
QilongTang pushed a commit that referenced this pull request Aug 5, 2019
* Fix tooltip for Spanish Civil 3D

In AutoCAD/Civil3D, `CurrentUICulture.ToString()` will return traditional `es-ES_tradnl`,
instead of plain `es-ES`. This will fail the finding of xml document later.

This change uses `CurrentUICulture.Name` instead.
From MS DOC for `CultureInfo.Name`:
> Gets the culture name in the format languagecode2-country/regioncode2.

* More fix for samples and gallery
QilongTang added a commit that referenced this pull request Aug 5, 2019
* Fix tooltip for Spanish Civil 3D

In AutoCAD/Civil3D, `CurrentUICulture.ToString()` will return traditional `es-ES_tradnl`,
instead of plain `es-ES`. This will fail the finding of xml document later.

This change uses `CurrentUICulture.Name` instead.
From MS DOC for `CultureInfo.Name`:
> Gets the culture name in the format languagecode2-country/regioncode2.

* More fix for samples and gallery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants