Fix warning message for indexing into lists, display fully qualified classname in warnings #9861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…classname in warnings
…s and dictionaries
| @@ -408,7 +416,7 @@ private void GetLocationByGraphNode(ref int line, ref int col) | |||
| var argsJoined = string.Join(", ", arguments.Select(GetTypeName)); | |||
|
|
|||
| var fep = funcGroup.FunctionEndPoints[0]; | |||
| var formalParamsJoined = string.Join(", ", fep.FormalParams.Select(x => x.ToShortString())); | |||
| var formalParamsJoined = string.Join(", ", fep.FormalParams); | |||
There was a problem hiding this comment.
is this going to use full class names when throwing function not found exceptions?
There was a problem hiding this comment.
Yes, this is the intended fix for https://jira.autodesk.com/browse/DYN-1044.
|
This looks good, just one comment. |
aparajit-pratap
added a commit
to aparajit-pratap/Dynamo
that referenced
this pull request
Jul 30, 2019
…classname in warnings (DynamoDS#9861) * fix warning message for indexing into lists, display fully qualified classname in warnings * display fully qualified class names in type mismatch and method resolution warnings * add resource strings for null reference exceptions with lists, strings and dictionaries * add comments
aparajit-pratap
added a commit
that referenced
this pull request
Jul 30, 2019
…ay fully qualified … (#9865) * Fix warning message for indexing into lists, display fully qualified classname in warnings (#9861) * fix warning message for indexing into lists, display fully qualified classname in warnings * display fully qualified class names in type mismatch and method resolution warnings * add resource strings for null reference exceptions with lists, strings and dictionaries * add comments * update test cases
aparajit-pratap
added a commit
that referenced
this pull request
Jul 30, 2019
* fix warning message for indexing into lists, display fully qualified classname in warnings * display fully qualified class names in type mismatch and method resolution warnings * add resource strings for null reference exceptions with lists, strings and dictionaries * add comments * update test cases
mjkkirschner
pushed a commit
that referenced
this pull request
Aug 3, 2019
…classname in warnings (#9861) * fix warning message for indexing into lists, display fully qualified classname in warnings * display fully qualified class names in type mismatch and method resolution warnings * add resource strings for null reference exceptions with lists, strings and dictionaries * add comments
mjkkirschner
pushed a commit
that referenced
this pull request
Aug 3, 2019
* fix warning message for indexing into lists, display fully qualified classname in warnings * display fully qualified class names in type mismatch and method resolution warnings * add resource strings for null reference exceptions with lists, strings and dictionaries * add comments * update test cases
horatiubota
added
the
error/warning/crash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
JIRA: https://jira.autodesk.com/browse/DYN-1487, https://jira.autodesk.com/browse/DYN-1044
The warning on the node no longer mentions
Get.ValueAtIndexand displays the appropriate error message:Declarations
Check these if you believe they are true
*.resxfilesReviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of