Publish Package with Host Multi-Selection

[QilongTang]

Please Note:

1. Before submitting the PR, please review How to Contribute to Dynamo
2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
3. PRs will be reviewed from oldest to newest
4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

This PR is about adding the host multi-selection and part of the regular package publishing workflow.

What I have tested:

• Host dependency will be optional filed for now, so dialog canSubmit check will not mandate it
• Publishing to local works fine with the right info serialized
• Publishing from existing package works fine with the right info pre filled in the combox
  

TODO:

• Refine the UI to see if we should simply add it below versions otherwise need to rewrite the combobox here since it does not fit..
  - [ ] Add publish check for host dependencies
• Add multi selection part

What it looks now

The pkg.json generated when publishing the package locally

{
   "license": "",
   "file_hash": null,
   "name": "Test",
   "version": "1.0.2",
   "description": "TestTestTestTest",
   "group": "",
   "keywords": null,
   "dependencies": [],
   "host_dependencies": [
       "Revit",
       "Civil 3D"
   ],
   "contents": "",
   "engine_version": "2.4.0.5716",
   "engine": "dynamo",
   "engine_metadata": "",
   "site_url": "",
   "repository_url": "",
   "contains_binaries": true,
   "node_libraries": [
       "Analysis, Version=2.3.0.4293, Culture=neutral, PublicKeyToken=null",
       "Analysis, Version=2.3.0.4293, Culture=neutral, PublicKeyToken=null"
   ]
}

Declarations

Check these if you believe they are true

• The code base is in a better state after this PR
• Is documented according to the standards
• The level of testing this PR includes is appropriate
• User facing strings, if any, are extracted into *.resx files
• All tests pass using the self-service CI.
• Snapshot of UI changes, if any.
• Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@DynamoDS/dynamo

FYIs

@Amoursol

[mjkkirschner]

@QilongTang the JSON here looks odd, why is the same dll added twice as a nodeLibrary?

[QilongTang]

@mjkkirschner I have no idea, was just using a random dll to test serialization

[mjkkirschner]

@QilongTang can you confirm that before your change the same node libraries json would have been generated...

 "node_libraries": [
       "Analysis, Version=2.3.0.4293, Culture=neutral, PublicKeyToken=null",
       "Analysis, Version=2.3.0.4293, Culture=neutral, PublicKeyToken=null"
   ]

and this is not a regression caused by this PR?

[QilongTang]

@mjkkirschner I can't reproduce it before or after my changes again.

[QilongTang]

Running self CI now

[QilongTang]

The only regression on self CI passed locally

[mjkkirschner]

@QilongTang whats the failure stack on ci?

[QilongTang]

@mjkkirschner I am running the self CI again now

Errors and Failures:
1) Test Failure : DynamoCoreWpfTests.PublishPackageViewModelTests.NewPackageVersionUpload_DoesNotThrowExceptionWhenDLLIsLoadedSeveralTimes
     Expected: No Exception to be thrown
  But was:   (Object reference not set to an instance of an object.)
   at Dynamo.PackageManager.PublishPackageViewModel.set_SelectedHosts(List`1 value) in E:\Builds\SSCI_Dynamo\DynamoDS_Dynamo\PublishPackageWithHost\src\DynamoCoreWpf\ViewModels\PackageManager\PublishPackageViewModel.cs:line 458
   at Dynamo.PackageManager.PublishPackageViewModel.FromLocalPackage(DynamoViewModel dynamoViewModel, Package l) in E:\Builds\SSCI_Dynamo\DynamoDS_Dynamo\PublishPackageWithHost\src\DynamoCoreWpf\ViewModels\PackageManager\PublishPackageViewModel.cs:line 728

Figured this out, this does not fail in VS 2019 but a null check for setter is apparently needed for lower version of C#

[reddyashish]

Looks good to me.

[QilongTang]

Addressed all comments, and all self CI passed now. Merging once all checks passed