Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct package install error dialog messages #9834

Merged
merged 1 commit into from
Jul 8, 2019

Conversation

aparajit-pratap
Copy link
Contributor

@aparajit-pratap aparajit-pratap commented Jul 8, 2019

Purpose

JIRA issue: https://jira.autodesk.com/browse/DYN-2026

In the case of a conflicting custom node package being installed, the "Cannot Download Package" dialog said that the already loaded package first needs to be uninstalled by Dynamo and Dynamo restarted. Then the user would need to try installing the package again. However, in this case the conflicting package is still downloaded even though it isn't loaded in the current Dynamo session. If the user selects "Yes" in the dialog, the already loaded package is deleted when Dynamo is restarted and he/she is not expected to reinstall the second package as it was already downloaded previously. When Dynamo is restarted the second package loads successfully after the original conflicting package is deleted.

The dialog message is updated to reflect this behavior more clearly:
Before:
image

After:
image

In addition this fixes an issue in a similar dialog where the package version wasn't explicit in the error message:
Before:
image

After:
image

TODO:

  • Cherry-pick into RC2.3.0 branch.

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI. [WIP]
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@QilongTang @reddyashish

FYIs

@mjkkirschner

@QilongTang
Copy link
Contributor

I was wondering about that during the demo! Thank you for fixing it!

@QilongTang
Copy link
Contributor

LGTM

@QilongTang QilongTang added the LGTM Looks good to me label Jul 8, 2019
@aparajit-pratap aparajit-pratap merged commit fe74bf4 into DynamoDS:master Jul 8, 2019
@aparajit-pratap aparajit-pratap deleted the message branch July 8, 2019 22:48
@horatiubota horatiubota added the error/warning/crash Issues mentioning a Dynamo error, warning or crash message label Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
error/warning/crash Issues mentioning a Dynamo error, warning or crash message LGTM Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants