Correct package install error dialog messages #9834
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
JIRA issue: https://jira.autodesk.com/browse/DYN-2026
In the case of a conflicting custom node package being installed, the "Cannot Download Package" dialog said that the already loaded package first needs to be uninstalled by Dynamo and Dynamo restarted. Then the user would need to try installing the package again. However, in this case the conflicting package is still downloaded even though it isn't loaded in the current Dynamo session. If the user selects "Yes" in the dialog, the already loaded package is deleted when Dynamo is restarted and he/she is not expected to reinstall the second package as it was already downloaded previously. When Dynamo is restarted the second package loads successfully after the original conflicting package is deleted.
The dialog message is updated to reflect this behavior more clearly:
Before:
After:
In addition this fixes an issue in a similar dialog where the package version wasn't explicit in the error message:
Before:
After:
TODO:
Declarations
Check these if you believe they are true
*.resx
filesReviewers
@QilongTang @reddyashish
FYIs
@mjkkirschner