-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit the tooltip width of Ports #9813
Conversation
@@ -67,7 +67,7 @@ | |||
<Grid.ToolTip> | |||
<dynui:DynamoToolTip AttachmentSide="{Binding Path=PortType, Converter={StaticResource PortToAttachmentConverter}}" Style="{DynamicResource ResourceKey=SLightToolTip}"> | |||
<Grid> | |||
<TextBlock Text="{Binding Path=ToolTipContent}"></TextBlock> | |||
<TextBlock MaxWidth="320" TextWrapping="Wrap" Text="{Binding Path=ToolTipContent}"></TextBlock> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate here how did you define 320
? If possible can you move the number to be a const number property?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found that the node Rectangle ToolTip was set width as 320. (
<TextBlock MaxWidth="320" |
So I just keep the same as it.
I am fine with us fixing it this way for now, LGTM as long as you put TODO comment for our team to move those magic numbers to resource strings |
OK @QilongTang @mjkkirschner , I have create an issue on DYN Jira(https://jira.autodesk.com/browse/DYN-2000), you can take a look at it if you have time ; ) |
@ZiyunShang Would you provide Jira link here or @ me and @mjkkirschner in it, otherwise we will not get a notification? Thanks! |
@QilongTang Ok, I have add the link here. |
@QilongTang @mjkkirschner could you help merge this? |
Purpose
Limit the tooltip width of Ports so that the bubble will not be very long.
Declarations
Check these if you believe they are true
*.resx
filesReviewers
@QilongTang @mjkkirschner
FYIs
@AndyDu1985