Reload preloaded libraries only if there are new packages to load #9801
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This is a small optimization to avoid having to reload all preloaded (out of the box) libraries (zero touch + DS files) IF there are no packages to be loaded.
The first time all preloaded libraries are loaded is during the instantiation of
DynamoModel
here:Dynamo/src/DynamoCore/Models/DynamoModel.cs
Line 733 in 43e501e
PackageManagerExtension
here:Dynamo/src/DynamoPackages/PackageManagerExtension.cs
Line 155 in 43e501e
Declarations
Check these if you believe they are true
*.resx
filesReviewers
@mjkkirschner
FYIs
@QilongTang