Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamo Package Dependency View Extension #9787
Dynamo Package Dependency View Extension #9787
Changes from 9 commits
1126ba5
4d9303a
6428ad8
226dd31
01ca109
57a91f9
1379d94
4dbdcc5
22992d0
abcce1f
7a270ad
7357094
e8c3667
d4c5a0b
5679bfe
dc748c7
27c05fc
63c6bd9
48346eb
4904b89
0bebfcc
23b06bb
5d483b1
6c4ede7
c4d57ef
924dca9
befc36a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems like an odd place to do this -couldn't the workspace be cleared for some other reason... and if you clear the workspace but then don't add the the subscription back then you're not watching the workspace any longer...
I would have imagined this would be done in the
onCurrentWorkspaceChanged
handler - you cache the current workspace, unsubscribe the handler, then get the new current workspace and then subscribe?Does that not work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to unsubscribe this event handler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see how this could always be the same workspace - but I think for safety's sake we should unsub this when the workspace changes and re sub it there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, I removed because this is causing crashes sometimes (I think I showed you).. Let me add it back and test