-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick language changes into 2.0.3 branch for Refinery #9730
Cherry-pick language changes into 2.0.3 branch for Refinery #9730
Conversation
This was missed while cherrypicking DynamoDS#9441
@reddyashish it looks like your 5th and 6th commits are not in chronological order. Did you come across any conflicts?
We need to be careful that no other changes have gone into these files outside of these cherry-picks. |
Have you run self-serve on this PR? |
@aparajit-pratap, the self serve has no regressions. The 5th and 6th commits are related to a one task(infinite loop bug) and the changes are made to different files compared to the other 4 commits. So there were no conflicts there. |
…ed in a different commit and is not needed here.
Removed the DsCoreDataTests file as this was introduced by a different PR https://github.com/DynamoDS/Dynamo/commits/master/test/DynamoCoreTests/DSCoreDataTests.cs. The changes to this file, that were done by this PR(#9388) are being ignored. |
@saintentropy PTAL |
LGTM! |
@saintentropy Since we will have daily build after this change, does it make sense for Black Team to also consume this build early and play with it? I expect installer change required still on your end to install Refinery on Dynamo 2.0.3 OOTB. Please check. |
Purpose
This PR is to cherry-pick language changes that went in after 2.0.3 branch was created.
Refer to this task for more information: https://jira.autodesk.com/browse/DYN-1879
The commits related to following tasks were cherry-picked:
Declarations
Check these if you believe they are true
*.resx
filesReviewers
@aparajit-pratap @mjkkirschner