Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quotation marks around comparison csv values #9703

Merged
merged 1 commit into from
May 7, 2019

Conversation

scottmitchell
Copy link
Collaborator

@scottmitchell scottmitchell commented May 7, 2019

Purpose

Fixes a bug where numerical values in the comparison csv which contain commas were interpreted as multiple values. The fix here is to surround each value with quotation marks.

The csv text now looks like this:

"RunGraph","Pottery","Base","9,867.57 ms","110.39 ms","39.36 ms"
"","","New","9,867.57 ms","110.39 ms","39.36 ms"
"","","","0%","0%","0%"

And it is now interpreted correctly by excel:
csvExcel

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@mjkkirschner

@scottmitchell scottmitchell requested a review from mjkkirschner May 7, 2019 15:43
@mjkkirschner
Copy link
Member

LGTM

@scottmitchell scottmitchell merged commit 28b67c5 into DynamoDS:master May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants