Dynamo Right Side Extensions Panel #9691
Conversation
|
have you considered adding a tabbed view so that the API adds a new tab with the extension name? That way extensions don't stomp on each other? |
|
@mjkkirschner It is definitely in my plan, similar to what we are doing in AVP but beyond. But I am looking at design first, I am debating on where the tabs should live, because I think it is cleaner if the tabs live outside of the right panel and replace the extensions grid once it is loaded. We can review together in person when you are available. There are some UX sweet spots here. |
|
@QilongTang whats the plan here, do we have a follow up task to realize this? |
|
@mjkkirschner I believe what we discussed is:
In short, we need a task to modify stuff based on team's comments in my UX proposal and review/merge this PR. Everything should be useful in this PR from my assessment so far, but we are missing the view injection UI for extensions to use. |
| </data> | ||
| <data name="PackagePathAutoAddNotificationDetailedDescription" xml:space="preserve"> | ||
| <value>The import path "{0}" was added to "Manage Node and Package Paths". If you want to update or remove this path, please open "Settings > Manage Node and Package Paths..."</value> | ||
| <value>The import path "{0}" was added to "Manage Node and Package Paths". If you want to update or remove this path, please open "Settings > Manage Node and Package Paths..."</value> |
There was a problem hiding this comment.
These changes are generated by VS, should be equivalent.
| </Grid.ColumnDefinitions> | ||
|
|
||
| <!--Titlebar--> | ||
| <Border BorderBrush="#FF3F4040" | ||
| BorderThickness="0,0,0,1" | ||
| Grid.Row="0" | ||
| Grid.Column="0" | ||
| Grid.ColumnSpan="3" | ||
| Grid.ColumnSpan="5" |
There was a problem hiding this comment.
If you guys find it difficult to understand why I made this change, that indicates team need knowledge share with me on WPF UI grid. I have shared why I had to expand the number here with @scottmitchell but would be happy to cover this with team
| <Grid Background="#353535" | ||
| Width="80" | ||
| Width="100" |
There was a problem hiding this comment.
I made both left and right side button to be 100px wide so they are symmetric
| <StackPanel Grid.Row="2" | ||
| Grid.Column="2" | ||
| Orientation="Vertical" | ||
| Name="collapsedSidebar" | ||
| Name="collapsedLibrarySidebar" |
There was a problem hiding this comment.
I wonder if we should consider these names public APIs?
There was a problem hiding this comment.
You mean so people could access these without looking at our code?
QilongTang
changed the title
|
Addressed all the comments, let me know |
|
After talking with Team at standup, merging. The actual API for extension view injection are being worked on and will be in a different PR |
* First Commit * Get Right Extension Grid in * Align the position of extensions button * Decouple collaps/uncollaps logic with left extension grid * Address Comments
Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
This PR is aiming to give proposal to new UX using multiple view extensions in Dynamo by prototyping Dynamo right side extensions panel within Dynamo main windows and provide API for extension developer to inject customized UI into Dynamo.
Current progress:
TODO (yes, a lot of TODOs)
Fix UI so that the drag and drop experience is seemless like library view extension on the left
Propose APIs so library view extension will use that to inject it self
Provide another view extension example using right side WPF grid
Use Dynamo with multiple view extension open at the same time and test
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mjkkirschner
FYIs
@DynamoDS/dynamo