-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-1754: As a developer I want detailed per node profiling during perf benchmarks #9667
Merged
Merged
Changes from 1 commit
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
56dbd73
Update changes from librarie.js to fix QNTM-3710
ColinDayOrg eec64b9
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
ColinDayOrg 4362151
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
ColinDayOrg 75643c7
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
ColinDayOrg 6a07e6c
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
ColinDayOrg 38b8461
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
ColinDayOrg 44a00a8
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
ColinDayOrg 5c04a06
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
ColinDayOrg a21fd6a
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
ColinDayOrg 4235133
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
ColinDayOrg 302b9dd
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
ColinDayOrg 6bf5548
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
ColinDayOrg 8d4511b
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
ColinDayOrg 8f9df0f
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
ColinDayOrg e91ef30
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
ColinDayOrg 82373cc
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
ColinDayOrg 1434ba0
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
ColinDayOrg 706974c
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
ColinDayOrg 760ae95
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
ColinDayOrg 6ffd883
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
ColinDayOrg 5b1c073
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
ColinDayOrg f11f924
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
ColinDayOrg 710c7ee
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
ColinDayOrg e8f5ade
Initial add and code cleanup for profiling data
ColinDayOrg f740c1d
Add profiling changes
ColinDayOrg 7644f6b
Add missing summaries and accessor items
ColinDayOrg dc0eb40
Add an accessor for the profiling data to the profiling session
ColinDayOrg 7e903d2
Make profiling session private
ColinDayOrg c1aee1d
Improve infrastructure (switch to property, make DateTime property n…
ColinDayOrg 3fc8b74
Add test for pre-run, post-run, and node deletion post-run
ColinDayOrg c5d3a1d
Remove unused AstCompilationEvents class
ColinDayOrg 0cb178c
Remove unused CompilationEventArgs class
ColinDayOrg c463ba3
Rename IProfilingData to IProfilingExecutionTimeData
ColinDayOrg f13049c
Remove derivation from NotificationObject
ColinDayOrg c228452
Restrict access to NodeProfilingData methods as much as possible
ColinDayOrg 43129bd
Pull strings out to constants
ColinDayOrg 320ae6b
Update naming
ColinDayOrg 6eb5cc5
Obsolete Node property getter and add NodeId property getter
ColinDayOrg edb88eb
Change property name from Node to NodeId and obsolete Node to avoid c…
ColinDayOrg b94aefd
Move profiling data housekeeping out of the engine controller
ColinDayOrg 9caccd6
Add the abillity to switch profiling on/off (off by default), includi…
ColinDayOrg 995ee9b
Move ownership of profiling data to the ast builder
ColinDayOrg 8e902db
minor code fixes
aparajit-pratap 3cb15a7
Merge pull request #1 from aparajit-pratap/DYN-1754
ColinDayOrg 7a82082
Fix typo
ColinDayOrg 9173bc8
Add public interface to get profiling data
ColinDayOrg 87564af
Merge branch 'DYN-1754' of https://github.com/ColinDayOrg/Dynamo into…
ColinDayOrg 686f72c
Add test for public data access method
ColinDayOrg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel this test is redundant; it's testing what is already being tested in the first test case you added, is it not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a little redundant, but it is testing the public data accessor as opposed to the other test that is using internal methods.