Move initial setup of IsAnalyticsReportingApproved to PreferenceSettings constructor

[DmytroMuravskyi]

Purpose

Alias integration needs control over analytics tick on the first run. To achieve this I moved the variable initialization from CheckIsFirstRun to PreferenceSettings constructor. This allows override IsAnalyticsReportingApproved before creating DynamoCore if needed. The only change to default Dynamo behavior I see is that now IsAnalyticsReportingApproved option can now migrate from previous Dynamo version instead of always being "true" during the first run. Please inform me what is the wanted behavior.

Declarations

Check these if you believe they are true

• The code base is in a better state after this PR
• Is documented according to the standards
• The level of testing this PR includes is appropriate
• User facing strings, if any, are extracted into *.resx files
• All tests pass using the self-service CI.
• Snapshot of UI changes, if any.
• Changes to the API follow

Reviewers

@mjkkirschner

[QilongTang]

@DmytroMuravskyi

1. Did you test if this would change the fact that every new version of Dynamo launched for user, they will see the analytics term of use first time when they launch it?
2. Can you explain the reason why you would like to propose such change? Do you mean on the first run of Alias, you always set IsAnalyticsReportingApproved to false?

[DmytroMuravskyi]

@QilongTang I didn't change migration behavior. Analytics term of use window would still appear during first run of every new version of Dynamo. I just removed hardcoded value set, because we need to set it as "false" by default if user has no previous preferences. The window, however, will show value of IsAnalyticsReportingApproved from migrated preferences of previous Dynamo version instead of always "true"

[QilongTang]

@DmytroMuravskyi Thanks! I verified locally and behavior change looks good to our team. However, unit tests are missing from this PR. I will add in a different PR.