-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graph Tessellation Benchmarks #9651
Conversation
|
Running self CI and ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work Aaron! Some minor comments, then LGTM.
tools/Performance/DynamoPerformanceTests/DynamoViewPerformanceTestBase.cs
Outdated
Show resolved
Hide resolved
Addressed some comments. Self CI passed, let me know what you think @aparajit-pratap |
All checks passed @aparajit-pratap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* Initial Commit * Updates to use HelixRenderPackageFactory * Disable tessellation or rendering during graph run * clean up * Clean Up * More Comments * more comments * Address Comments * Move test file into performance test project
Please Note:
DynamoRevit
repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTM
label is added to the PR.Purpose
This PR:
Declarations
Check these if you believe they are true
*.resx
filesReviewers
@mjkkirschner @scottmitchell
FYIs
@sm6srw