Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph Tessellation Benchmarks #9651

Merged
merged 11 commits into from
Apr 15, 2019
Merged

Graph Tessellation Benchmarks #9651

merged 11 commits into from
Apr 15, 2019

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Apr 11, 2019

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

This PR:

  1. Split the graph run earlier (which include evaluation, tessellation and run) into two part. I. Run II. Tessellation and Run
  2. Moved GeometryHolder class to DynamoCore so test class can refer to easily. FYI: @sm6srw I think this is OK but let me know if you have concerns
    image

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@mjkkirschner @scottmitchell

FYIs

@sm6srw

@mjkkirschner
Copy link
Member

mjkkirschner commented Apr 14, 2019

"C:\projects\dynamo\src\Dynamo.All.sln" (default target) (1) ->
7155"C:\projects\dynamo\test\DynamoCoreWpfTests\DynamoCoreWpfTests.csproj" (default target) (62) ->
7156(CoreCompile target) -> 
7157  GraphViewTests.cs(41,54): error CS0122: 'DefaultWatch3DViewModel.UnregisterNodeEventHandlers(NodeModel)' is inaccessible due to its protection level [C:\projects\dynamo\test\DynamoCoreWpfTests\DynamoCoreWpfTests.csproj] 

@QilongTang QilongTang changed the title [WIP] Graph Tessellation Benchmarks Graph Tessellation Benchmarks Apr 15, 2019
@QilongTang QilongTang added the PTAL Please Take A Look 👀 label Apr 15, 2019
@QilongTang
Copy link
Contributor Author

Running self CI and ready for review

Copy link
Contributor

@aparajit-pratap aparajit-pratap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Aaron! Some minor comments, then LGTM.

test/DynamoCoreWpfTests/GraphViewTests.cs Outdated Show resolved Hide resolved
test/DynamoCoreWpfTests/GraphViewTests.cs Outdated Show resolved Hide resolved
src/DynamoCoreWpf/Properties/AssemblyInfo.cs Show resolved Hide resolved
test/DynamoCoreWpfTests/GraphViewTests.cs Outdated Show resolved Hide resolved
@QilongTang
Copy link
Contributor Author

Addressed some comments. Self CI passed, let me know what you think @aparajit-pratap

@QilongTang
Copy link
Contributor Author

All checks passed @aparajit-pratap

Copy link
Contributor

@aparajit-pratap aparajit-pratap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@QilongTang QilongTang merged commit 33b715f into master Apr 15, 2019
@QilongTang QilongTang deleted the GraphViewRendering branch April 15, 2019 21:12
@QilongTang QilongTang removed the PTAL Please Take A Look 👀 label Apr 15, 2019
mjkkirschner pushed a commit that referenced this pull request Aug 3, 2019
* Initial Commit

* Updates to use HelixRenderPackageFactory

* Disable tessellation or rendering during graph run

* clean up

* Clean Up

* More Comments

* more comments

* Address Comments

* Move test file into performance test project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants