-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamo View Performance Benchmarks #9623
Conversation
1. introduce helper for grabbing config 2. introduce a second performance test case 3. make the console app entrance cleaner
This PR is ready for review in terms of getting view execution time, I will investigate at how to get render time |
tools/Performance/DynamoPerformanceTests/DynamoViewModelPerformanceTestBase.cs
Outdated
Show resolved
Hide resolved
tools/Performance/DynamoPerformanceTests/PerformanceTestHelper.cs
Outdated
Show resolved
Hide resolved
tools/Performance/DynamoPerformanceTests/DynamoModelPerformanceTestBase.cs
Outdated
Show resolved
Hide resolved
tools/Performance/DynamoPerformanceTests/DynamoPerformanceTests.csproj
Outdated
Show resolved
Hide resolved
tools/Performance/DynamoPerformanceTests/DynamoViewPerformanceTestBase.cs
Outdated
Show resolved
Hide resolved
tools/Performance/DynamoPerformanceTests/DynamoViewPerformanceTestBase.cs
Show resolved
Hide resolved
tools/Performance/DynamoPerformanceTests/DynamoModelPerformanceTestBase.cs
Outdated
Show resolved
Hide resolved
tools/Performance/DynamoPerformanceTests/PerformanceTestHelper.cs
Outdated
Show resolved
Hide resolved
tools/Performance/DynamoPerformanceTests/PerformanceTestHelper.cs
Outdated
Show resolved
Hide resolved
tools/Performance/DynamoPerformanceTests/PerformanceTestHelper.cs
Outdated
Show resolved
Hide resolved
tools/Performance/DynamoPerformanceTests/PerformanceTestHelper.cs
Outdated
Show resolved
Hide resolved
Other than a couple of comments about documentation and the empty class, LGTM. |
Addressed comments, please take a look @ColinDayOrg @aparajit-pratap |
@QilongTang just one last question about the reasoning for selection of the fast config settings for iteration count, warmup count, etc. Is there some heuristic you used to come up with these numbers? |
LGTM |
@aparajit-pratap @ColinDayOrg These numbers are not fixed, we should tune those. I decided these as first version because these numbers make sure the graph run with view along can be finished within an hour, the model tests finished within 15 minutes. And the number I got is quite stable and as good as before. After we hook up the benchmark with CI, we should change these numbers and decide best times to run and warmup, etc. Maybe instead of |
Please Note:
DynamoRevit
repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTM
label is added to the PR.Purpose
This PR:
PerformanceTestHelper
FastBenchmarkReleaseConfig
as default performance benchmark job. It contains DynamoMaxWarmuoCount = 9, DynamoMaxIterationCount = 9 to avoid the case, the benchmark sometimes runs forever and reach to the 100 times internal limit.DebugInProcessConfig
as an alternative config that dev can apply locally for debugging benchmark runningTime consumption running view benchmarks with the current suite:
Time consumption running model benchmarks with the current suite:
Declarations
Check these if you believe they are true
*.resx
filesReviewers
@ColinDayOrg @scottmitchell @aparajit-pratap
FYIs
@DynamoDS/dynamo