Trace thread local performance refactor #9620
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saintentropy
changed the title
| { | ||
| var val = traceRet[TRACE_KEY]; | ||
| newTraceData.Data = val; |
There was a problem hiding this comment.
So in the case of ret being null, it looks like earlier newTraceData.Data was also being set to null. Now that there's an else condition, is that no longer the case?
There was a problem hiding this comment.
Looks like newTraceData.Data should always be null as you arrive here. Setting to null would be unnecessary.
| @@ -1,98 +0,0 @@ | |||
| using System; | |||
There was a problem hiding this comment.
I think we should obsolete this class and not remove it yet just so we don't break the API for binary compatibility and make a note to remove this in 3.0.
Merged
7 tasks
|
Closing this in favor of #9665 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this PR is move the backing implementation in
TraceUtilsfrom a thread data slot to a thread relative static field per Microsofts recommendations for performance.. This backing implementation is the data mechanism the VM utilizes to send information to and receive information from the zero-touch and NodeModel nodes invoked function contexts outside of the typical input parameters and return values. This PR does not relate to the other half of trace which is the serialization/deserialization of trace data to/from the .DYN file nor the data structure in the VM that keeps track of the current trace values per CallSite. This PR does not change the public API's in DynamoService for use of trace with a Node (ieGetTraceDataandSetTraceData). It does however simplify the internal methods utilized within the VM to set, get, and clear trace.Declarations
Check these if you believe they are true
*.resxfilesReviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of