continue custom node element binding issues pt1

[mjkkirschner]

Purpose

continues this PR from @aparajit-pratap : #9527
please see his PR for a very good writeup of the issue and explanation of his fix.

I'm doing some testing and adding automated tests. Also considering edge cases that might arise.

Declarations

Check these if you believe they are true

• The code base is in a better state after this PR
• Is documented according to the standards
• The level of testing this PR includes is appropriate
• User facing strings, if any, are extracted into *.resx files
• All tests pass using the self-service CI.
• Snapshot of UI changes, if any.
• Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@aparajit-pratap
@scottmitchell

FYIs

@smangarole
@ZiyunShang
@AndyDu1985

[mjkkirschner]

test files are something like this:

where the callsite data has been generated manually, encoded into base64 and added to the file - then the functionScope has been altered to something like 1000 definitely not what the compiler would generate at runtime.

[scottmitchell]

LGTM!

[aparajit-pratap]

@mjkkirschner do any of the tests you added test the case where (1) there are more than one creation nodes inside the same custom node definition?

[aparajit-pratap]

Can't we just use AssertNoDummyNodes function here?

[mjkkirschner]

currently I think that method is only implemented for system tests: this is a model test - do you want me to implement something like that in modelTestBase?

• we also still need to check if the custom node was loaded as when it fails it's not marked as a dummy node.

[mjkkirschner]

@aparajit-pratap - yes, the custom node definition here has two creation nodes with the same name / function signature inside it.

[aparajit-pratap]

LGTM!