Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-1681a: As a Dynamo user, I want to resize the Set Value dialog #9600

Merged
merged 2 commits into from
Apr 16, 2019

Conversation

scottmitchell
Copy link
Collaborator

Purpose

This PR addresses the first part of DYN-1681, which is to allow users to resize the Set Value dialog so that they can see more of the text they are editing.
This PR does not replicate Group text editing functionality for Notes.

EditWindow_1

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

FYIs

@radumg
Copy link
Collaborator

radumg commented Apr 3, 2019

Finally ! thanks @scottmitchell !

@QilongTang
Copy link
Contributor

QilongTang commented Apr 15, 2019

LGTM after unit test

@QilongTang
Copy link
Contributor

@scottmitchell @mjkkirschner Forgot how we conclude to unit test this, do you recall?

@scottmitchell
Copy link
Collaborator Author

scottmitchell commented Apr 15, 2019

@QilongTang Yes, unit test is part of the AC. Working on that now. I was thinking the test should ensure the window cannot become larger than the screen. Anything else we should test here?

@scottmitchell
Copy link
Collaborator Author

Merging this PR and creating a new task to test this functionality with a Selenium test.

@scottmitchell scottmitchell merged commit 8cfe30b into DynamoDS:master Apr 16, 2019
@Amoursol
Copy link
Contributor

@scottmitchell A few points from testing:

  • Windows ran through Parallels
  • Screen resolution: 3360 x 1880

Can we please make the minimum values honour the default open values, or something more appropriate than this? This also breaks the graphical icons of Minimize/Expand/Close.

image

Having 'Set Value...' up here doesn't make sense to a typical Dynamo user. Please rename to 'Write note here'

image

This is super cool!

Dynamo_pull9600_ResizeNote

mjkkirschner pushed a commit that referenced this pull request Aug 3, 2019
…9600)

* Added resizing for EditWindow

* Added MaxHeight and MaxWidth to Edit Window
@Amoursol Amoursol mentioned this pull request Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants